All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <Anand.Jain@oracle.com>
To: xin.zhong@intel.com
Cc: Hugo Mills <hugo@carfax.org.uk>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: [PATCH V2] Btrfs-progs: add \"btrfs subvolume get-default\" subcommand
Date: Wed, 15 Feb 2012 13:43:02 +0800	[thread overview]
Message-ID: <4F3B45E6.3000008@oracle.com> (raw)
In-Reply-To: <1310374571-20811-1-git-send-email-xin.zhong@intel.com>


Hi Xin / Hugo,
  
  I am referring to
  git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

  has miss match parameter list for list_subvols
  ----------
  # cd btrfs-progs
  # egrep list_subvols *
  btrfs_cmds.c:	ret = list_subvols(fd, print_parent, 0);
  btrfs_cmds.c:	ret = list_subvols(fd, 0, 1);
  btrfs_cmds.h:int list_subvols(int fd, int print_parent, int get_default);  <-----
  btrfs-list.c:int list_subvols(int fd, int print_parent)  <-----
  ----------

  ----------
  # egrep -A 3 list_subvols btrfs-list.c
  int list_subvols(int fd, int print_parent)
  {
	struct root_lookup root_lookup;
	struct rb_node *n;
  ----------
  
  Looks like the following patch was checked in partially.
    http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg11103.html

  Could you pls take a look / comment.

thxs, -Anand


  parent reply	other threads:[~2012-02-15  5:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11  8:56 [PATCH V2] Btrfs-progs: add "btrfs subvolume get-default" subcommand Zhong, Xin
2011-07-11 14:11 ` Andreas Philipp
2011-07-12  2:43   ` Zhong, Xin
2012-02-15  5:43 ` Anand Jain [this message]
2012-02-15 16:35   ` [PATCH V2] Btrfs-progs: add \"btrfs subvolume get-default\" subcommand Ilya Dryomov
2011-07-11 12:02 R: [PATCH V2] Btrfs-progs: add "btrfs subvolume get-default" subcommand Goffredo Baroncelli <kreijack@libero.it>
2011-07-12  2:48 ` Zhong, Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3B45E6.3000008@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=hugo@carfax.org.uk \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xin.zhong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.