From: Sergei Shtylyov <sshtylyov@mvista.com>
To: meng zhang <meng.zhang@mediatek.com>
Cc: smurf@smurf.noris.de, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces
Date: Fri, 24 Feb 2012 15:31:33 +0400 [thread overview]
Message-ID: <4F477515.1040303@mvista.com> (raw)
In-Reply-To: <CACwCHpxjhEenzv+H3zK2cNKAA9KyuK=DPythY2UgHTmY_AhqaQ@mail.gmail.com>
Hello.
On 24-02-2012 10:41, meng zhang wrote:
> from: Meng Zhang<meng.zhang@mediatek.com>
> 1. This patch is based on kernel 3.0.0
You should base on the recent kernel instead.
> 2. To declare the product IDs in option.c
> Signed-off-by: Meng Zhang<meng.zhang@mediatek.com>
> ---------------------------------------------------------------------------------------
This line is not needed here.
> --- option.c 2012-02-23 10:42:40.635138657 +0800
> +++ option.c.orig 2011-10-07 22:50:04.000000000 +0800
The patch should be applicablke with -p1 switch, i.e. based on the linux
source root.
[...]
> @@ -1008,10 +1005,6 @@ static const struct usb_device_id option
> { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) }, /* CT-650
> CDMA 450 1xEVDO modem */
> { USB_DEVICE(ONDA_VENDOR_ID, ONDA_MT825UP) }, /* ONDA MT825UP modem */
> { USB_DEVICE_AND_INTERFACE_INFO(SAMSUNG_VENDOR_ID,
> SAMSUNG_PRODUCT_GT_B3730, USB_CLASS_CDC_DATA, 0x00, 0x00) }, /*
> Samsung GT-B3730 LTE USB modem.*/
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x00, 0x00) },
You're not adding the device IDs, you're removing them.
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff,
> 0x02, 0x01) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x00, 0x00) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff,
> 0x02, 0x01) }, /* MediaTek MT6276M modem& app port */
The patch is line wrapped.
WBR, Sergei
next prev parent reply other threads:[~2012-02-24 11:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 6:41 [PATCH] USB: option: Add MediaTek MT6276M modem&app interfaces meng zhang
2012-02-24 11:31 ` Sergei Shtylyov [this message]
2012-02-24 15:40 ` Greg KH
2012-02-24 8:04 meng zhang
2012-02-27 4:11 Meng Zhang (张萌)
2012-02-27 11:06 ` Sergei Shtylyov
2012-02-27 11:57 ` Meng Zhang (张萌)
2012-02-27 4:57 Meng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F477515.1040303@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=meng.zhang@mediatek.com \
--cc=smurf@smurf.noris.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.