From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11ow-00086b-B3 for qemu-devel@nongnu.org; Fri, 24 Feb 2012 15:32:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S11ov-000505-2h for qemu-devel@nongnu.org; Fri, 24 Feb 2012 15:32:50 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:42909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S11ou-0004zq-SL for qemu-devel@nongnu.org; Fri, 24 Feb 2012 15:32:49 -0500 Received: by eeit10 with SMTP id t10so661072eei.4 for ; Fri, 24 Feb 2012 12:32:47 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4F47F3DE.7030208@redhat.com> Date: Fri, 24 Feb 2012 21:32:30 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1329930815-7995-1-git-send-email-fsimonce@redhat.com> <1330102144-14491-2-git-send-email-fsimonce@redhat.com> <20120224170143.78f55d3e@doriath.home> In-Reply-To: <20120224170143.78f55d3e@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, Federico Simoncelli , mtosatti@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On 02/24/2012 08:01 PM, Luiz Capitulino wrote: > IMO, you could require the filename arguments to be escaped already. The monitor command was introduced exactly to avoid having to worry about details such as escaping. JSON is already supposed to take care of those. That said, I think Eric is right that we need to specify the formats, so we'll need another iteration, and we probably need to rename the command to drive-migrate too. Paolo