From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>,
lcapitulino@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command
Date: Mon, 27 Feb 2012 17:51:19 +0100 [thread overview]
Message-ID: <4F4BB487.6080001@redhat.com> (raw)
In-Reply-To: <4F4BA56B.7040608@redhat.com>
On 02/27/2012 04:46 PM, Kevin Wolf wrote:
> > + /*
> > + * Now we will drain, flush, & pivot everything - we are committed at this
> > + * point.
> > + */
> > + bdrv_drain_all();
>
> I would feel more comfortable if we could do the bdrv_drain_all() at the
> very beginning of the function. Not that I know of a specific scenario
> that would go wrong, but you have a nested main loop here that could do
> more or less anything.
The same could be said of a bdrv_read or a bdrv_write done by bdrv_open, no?
Paolo
next prev parent reply other threads:[~2012-02-27 16:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 19:31 [Qemu-devel] [PATCH v2 0/2] Group Live Snapshots Jeff Cody
2012-02-26 19:31 ` [Qemu-devel] [PATCH v2 1/2] qapi: Introduce blockdev-group-snapshot-sync command Jeff Cody
2012-02-27 11:13 ` Stefan Hajnoczi
2012-02-27 14:26 ` Jeff Cody
2012-02-27 14:40 ` Stefan Hajnoczi
2012-02-27 15:23 ` Jeff Cody
2012-02-27 15:31 ` Stefan Hajnoczi
2012-02-27 15:46 ` Kevin Wolf
2012-02-27 16:51 ` Paolo Bonzini [this message]
2012-02-27 17:02 ` Jeff Cody
2012-02-27 17:22 ` Kevin Wolf
2012-02-27 17:31 ` Jeff Cody
2012-02-26 19:31 ` [Qemu-devel] [PATCH v2 2/2] QMP: Add qmp command for blockdev-group-snapshot-sync Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BB487.6080001@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.