All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Virdi <amit.virdi@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Enable high speed support for USB device framework and usbtty
Date: Fri, 2 Mar 2012 11:24:45 +0530	[thread overview]
Message-ID: <4F5060A5.9060906@st.com> (raw)
In-Reply-To: <201202292224.17205.marex@denx.de>

Hi Marek,

>>>> +#if defined(CONFIG_USBD_HS)
>>>> +/**
>>>> + * usbd_device_qualifier_descriptor
>>>> + * @device: which device
>>>> + * @port: which port
>>>> + *
>>>> + * Return the specified qualifier descriptor for the specified device.
>>>> + */
>>>> +struct usb_qualifier_descriptor *usbd_device_qualifier_descriptor(
>>>> +		struct usb_device_instance *device, int port)
>>>
>>> Make this static, but do you really need this function at all?
>>
>> Well... usbd_device_qualifier_descriptor can't be static as the function
>> is called from another file (ep0.c). However, since it is used only for
>> EP0, it can be omitted for the time being keeping in mind we might need
>> to define it in future (if the need arises). What do you think?
>
> What do you mean. If this is called from ep0.c, it has to be exported and that's
> how it is. On the other hand, if ep0.c already has access to the "device", it
> can directly access the device_descriptor field, which is I believe expressive
> enough.
>

Yes, ep0.c has direct access to the "device" field. I'll omit the 
usbd_device_qualifier_descriptor function in V2.

Thanks
Amit Virdi

  reply	other threads:[~2012-03-02  5:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-27  9:35 [U-Boot] [PATCH] Enable high speed support for USB device framework and usbtty Amit Virdi
2012-02-27 11:41 ` Marek Vasut
2012-02-29 10:03   ` Amit Virdi
2012-02-29 21:24     ` Marek Vasut
2012-03-02  5:54       ` Amit Virdi [this message]
2012-03-02 10:41         ` Marek Vasut
2012-03-18 22:57           ` Marek Vasut
2012-03-19  9:31             ` Shiraz Hashim
2012-03-19 10:28               ` Marek Vasut
2012-03-26  4:46                 ` Amit Virdi
2012-03-26 10:41                   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5060A5.9060906@st.com \
    --to=amit.virdi@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.