From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33511)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S6BD8-0003bJ-Iw
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 20:35:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S6BD6-0001Vr-SK
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 20:35:06 -0500
Received: from cantor2.suse.de ([195.135.220.15]:38777 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S6BD6-0001UI-Ls
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 20:35:04 -0500
Message-ID: <4F5AAFC6.9040202@suse.de>
Date: Sat, 10 Mar 2012 02:35:02 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1330893156-26569-2-git-send-email-afaerber@suse.de>
	<4F5485F6.9060109@redhat.com>
In-Reply-To: <4F5485F6.9060109@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 1/3] kvmclock: Always register type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>, anthony@codemonkey.ws, lcapitulino@redhat.com

Am 05.03.2012 10:23, schrieb Avi Kivity:
> On 03/04/2012 10:32 PM, Andreas F=C3=A4rber wrote:
>> Currently, the "kvmclock" type is only registered when kvm_enabled().
>>
>> This breaks when moving type registration to before command line
>> parsing (so that QOM types can be used for CPU and machine).
>>
>> Since the QOM classes are lazy-initialized anyway and kvmclock_create(=
)
>> has another kvm_enabled() check, simply drop the KVM check in
>> kvmclock_register_types().
>>
>> kvm-i8259, kvm-apic and kvm-ioapic do not suffer from such a check.
>=20
> Patch looks good.

Ping for series.

Avi, do you want to sign this patch off through uq/master? Or should I
make the above a Reviewed-by (and remove the Cc:) within this series?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg