From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Virdi <amit.virdi@st.com>
Date: Mon, 12 Mar 2012 18:08:38 +0530
Subject: [U-Boot] [PATCH 10/25] SPEAr: Change the default environment
	variables
In-Reply-To: <201203071503.38601.sr@denx.de>
References: <1331121854-20494-1-git-send-email-amit.virdi@st.com>
	<1331121854-20494-11-git-send-email-amit.virdi@st.com>
	<201203071503.38601.sr@denx.de>
Message-ID: <4F5DEE4E.6080501@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Stefan,

>> Signifacance of CONFIG_EXTRA_ENV_UNLOCK:
>> This env variable is read by the cfi driver to unlock all flash sectors.
>> This is necessary because the Parallel NOR flash connected on the spear
>> boards, M28W64, has all its sectors in locked state at reset and these
>> have to be unlocked explicitly before being erased or written.
>
> But this is not needed for boards not using the common CFI flash driver. As
> the SPEAr600 based ones. So please only define it for board using the CFI
> driver.
>

Ok. I would undefine it from the spear-common file and define it for 
SPEAr310 board file only.

>> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
>> Signed-off-by: Shiraz Hashim<shiraz.hashim@st.com>
>> Signed-off-by: Amit Virdi<amit.virdi@st.com>
>
> Other than my comment above:
>
> Acked-by: Stefan Roese<sr@denx.de>
>

Thanks.

Regards
Amit Virdi