All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/5] Split xcb-util into separate packages.
Date: Mon, 12 Mar 2012 14:06:33 -0700	[thread overview]
Message-ID: <4F5E6559.9010505@linux.intel.com> (raw)
In-Reply-To: <CAHod+Ge8QmNp5TXhoKnqLR_2s+eGg=jOWLG2keAoCYFjTs3ByA@mail.gmail.com>

On 03/10/2012 07:49 AM, Marko Katić wrote:
> xcb-util was split into separate packages during the 0.3.6 -> 0.3.8
> transition.
> Change xcb-util.inc to reflect that.
>
This patch series looks OK, but the comment need refining.

First it's best to have correctly Subjects that list the file or recipe 
area being addressed and then what's the summary

For example in this case:

xcb-util: Remove packaging and modify SRC_URI for multiple ${PN} names

xcb-util was split into separate packages during the 0.3.6 -> 0.3.8 
transition, so update the .inc file to reflect that by removing the 
older packaging.

The reset of this series needs similar updates to commit messages.

Also, if possible can you use a git repo (request an oe-core or poky 
branch).
>
>
> diff --git a/meta/recipes-graphics/xcb/xcb-util.inc
> b/meta/recipes-graphics/xcb/xcb-util.inc
> index cd9923d..5e77a22 100644
> --- a/meta/recipes-graphics/xcb/xcb-util.inc
> +++ b/meta/recipes-graphics/xcb/xcb-util.inc
> @@ -18,20 +18,6 @@ DEPENDS += "gperf-native"
>   PARALLEL_MAKE = ""
> -SRC_URI = "http://xcb.freedesktop.org/dist/xcb-util-${PV}.tar.bz2"
> -
> -PACKAGES =+ "libxcbatom libxcbaux libxcbevent libxcbicccm \
> -             libxcbimage libxcbkeysyms libxcbproperty \
> -             libxcbreply libxcbwm"
> -
> -FILES_libxcbatom = "${libdir}/libXCBAtom.so.*"
> -FILES_libxcbaux = "${libdir}/libXCBAux.so.*"
> -FILES_libxcbevent = "${libdir}/libXCBEvent.so.*"
> -FILES_libxcbicccm = "${libdir}/libXCBICCCM.so.*"
> -FILES_libxcbimage = "${libdir}/libXCBImage.so.*"
> -FILES_libxcbkeysyms = "${libdir}/libXCBKeysyms.so.*"
> -FILES_libxcbproperty = "${libdir}/libXCBProperty.so.*"
> -FILES_libxcbreply = "${libdir}/libXCBReply.so.*"
> -FILES_libxcbwm = "${libdir}/libXCBWM.so.*"
> +SRC_URI = "http://xcb.freedesktop.org/dist/${PN}-${PV}.tar.bz2"
>   inherit autotools pkgconfig
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



  reply	other threads:[~2012-03-12 21:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-10 15:49 [PATCH 1/5] Split xcb-util into separate packages Marko Katić
2012-03-12 21:06 ` Saul Wold [this message]
2012-03-13  0:18 ` Saul Wold
2012-03-13 18:51 ` Yury Bushmelev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5E6559.9010505@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.