From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1S7OjB-0004vp-6W
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:13:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1S7Oin-0006TQ-5t
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:13:12 -0400
Received: from thoth.sbs.de ([192.35.17.2]:26562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1S7Oim-0006Sw-SA
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 06:12:49 -0400
Message-ID: <4F5F1D95.7000807@siemens.com>
Date: Tue, 13 Mar 2012 11:12:37 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1331557893-30806-1-git-send-email-marcandre.lureau@redhat.com>
	<4F5E4628.8050706@codemonkey.ws>
	<CAJ+F1C+_X4_G_TF2g3YCU7iFQZDHH250HNg=wOoQ4_8s78HVGQ@mail.gmail.com>
	<4F5E470A.5040909@codemonkey.ws> <20120312212206.GA19058@illuin>
In-Reply-To: <20120312212206.GA19058@illuin>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG
 format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@redhat.com>, =?ISO-8859-1?Q?Marc-Andr=E9_?= =?ISO-8859-1?Q?Lureau?= <marcandre.lureau@gmail.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

On 2012-03-12 22:22, Michael Roth wrote:
> On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote:
>> On 03/12/2012 01:56 PM, Marc-Andr=E9 Lureau wrote:
>>> On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguori<anthony@codemonkey.w=
s>  wrote:
>>>> Why not just return the screendump through QMP?
>>>
>>> in base64, base85?
>>
>> I think Jan had patches for base64 blobs but I think it got tangled
>> up in VMState related controversy.
>=20
> Few months back, was planning on using them for qemu-ga. Looks like
> they're not in yet, but FWIW qemu-ga has been using g_base64_encode() s=
ince
> initial commit. I think Jan had some reservations about g_base64_decode=
()'s
> error-handling, but that shouldn't be an issue in this particular case.

Yes, please don't use glib for this, just introduce a proper
error-checking implementation to QEMU. glib would require some revision
of this API to fix its deficits (still possible long-term, though).

Jan

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux