Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes

From: "Andreas Färber" <afaerber@suse.de>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com, jasowang@redhat.com,
	qemu-devel@nongnu.org, blauwirbel@gmail.com,
	hpoussin@reactos.org
Subject: Re: [Qemu-devel] [RESEND PATCH] vmstate: fix varrays with uint32_t indexes
Date: Tue, 13 Mar 2012 17:38:52 +0100	[thread overview]
Message-ID: <4F5F781C.4080502@suse.de> (raw)
In-Reply-To: <20120313060536.7941.37036.stgit@dhcp-8-167.nay.redhat.com>

Am 13.03.2012 07:05, schrieb Amos Kong:
> VMSTATE_VARRAY_UINT32() is used in hw/ds1225y.c, and we checked
> VMS_VARRAY_UINT32 bit of field->flags in vmstate_load_state(),
> but we don't check this bit in vmstate_save_state().

So what were the symptoms? Does this need to be backported to stable?

Andreas

> 
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
>  savevm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/savevm.c b/savevm.c
> index 80be1ff..694eaa4 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1486,6 +1486,8 @@ void vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd,
>                  n_elems = field->num;
>              } else if (field->flags & VMS_VARRAY_INT32) {
>                  n_elems = *(int32_t *)(opaque+field->num_offset);
> +            } else if (field->flags & VMS_VARRAY_UINT32) {
> +                n_elems = *(uint32_t *)(opaque+field->num_offset);
>              } else if (field->flags & VMS_VARRAY_UINT16) {
>                  n_elems = *(uint16_t *)(opaque+field->num_offset);
>              } else if (field->flags & VMS_VARRAY_UINT8) {

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg