From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH] arm/tegra: pcie: fix return value of function Date: Tue, 13 Mar 2012 13:36:27 -0600 Message-ID: <4F5FA1BB.5050002@wwwdotorg.org> References: <1331617587-10714-1-git-send-email-mad_soft@inbox.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1331617587-10714-1-git-send-email-mad_soft-aPYA7nAdAYY@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Artamonow Cc: Olof Johansson , Colin Cross , Mike Rapoport , Thierry Reding , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andi , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 03/12/2012 11:46 PM, Dmitry Artamonow wrote: > In previous patch (arm/tegra: add timeout to PCIe PLL lock detection loop) > tegra_pcie_enable_controller() function type has been changed from > void to int, but the last return statement wasn't converted, so > function returns undefined value. Fix it. > > Also while at it, address couple of minor concerns raised by reviewers: > use usleep_range for delay, and lower the value of timeout to 300ms > to be consistent with Nvidia Vibrante kernel. > > Signed-off-by: Dmitry Artamonow Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759554Ab2CMTgc (ORCPT ); Tue, 13 Mar 2012 15:36:32 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:34459 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753448Ab2CMTga (ORCPT ); Tue, 13 Mar 2012 15:36:30 -0400 Message-ID: <4F5FA1BB.5050002@wwwdotorg.org> Date: Tue, 13 Mar 2012 13:36:27 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15 MIME-Version: 1.0 To: Dmitry Artamonow CC: Olof Johansson , Colin Cross , Mike Rapoport , Thierry Reding , linux-tegra@vger.kernel.org, Andi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm/tegra: pcie: fix return value of function References: <1331617587-10714-1-git-send-email-mad_soft@inbox.ru> In-Reply-To: <1331617587-10714-1-git-send-email-mad_soft@inbox.ru> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/2012 11:46 PM, Dmitry Artamonow wrote: > In previous patch (arm/tegra: add timeout to PCIe PLL lock detection loop) > tegra_pcie_enable_controller() function type has been changed from > void to int, but the last return statement wasn't converted, so > function returns undefined value. Fix it. > > Also while at it, address couple of minor concerns raised by reviewers: > use usleep_range for delay, and lower the value of timeout to 300ms > to be consistent with Nvidia Vibrante kernel. > > Signed-off-by: Dmitry Artamonow Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 13 Mar 2012 13:36:27 -0600 Subject: [PATCH] arm/tegra: pcie: fix return value of function In-Reply-To: <1331617587-10714-1-git-send-email-mad_soft@inbox.ru> References: <1331617587-10714-1-git-send-email-mad_soft@inbox.ru> Message-ID: <4F5FA1BB.5050002@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/12/2012 11:46 PM, Dmitry Artamonow wrote: > In previous patch (arm/tegra: add timeout to PCIe PLL lock detection loop) > tegra_pcie_enable_controller() function type has been changed from > void to int, but the last return statement wasn't converted, so > function returns undefined value. Fix it. > > Also while at it, address couple of minor concerns raised by reviewers: > use usleep_range for delay, and lower the value of timeout to 300ms > to be consistent with Nvidia Vibrante kernel. > > Signed-off-by: Dmitry Artamonow Acked-by: Stephen Warren