All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] ns16550: tegra: Specify debugging serial port at boot.
Date: Tue, 13 Mar 2012 14:12:05 -0600	[thread overview]
Message-ID: <4F5FAA15.7030801@wwwdotorg.org> (raw)
In-Reply-To: <20120308183903.4575B202D69@gemini.denx.de>

On 03/08/2012 11:39 AM, Wolfgang Denk wrote:
> Dear Stephen Warren,
> 
> In message <4F58F5B8.6070402@wwwdotorg.org> you wrote:
>>
>> I noticed this patch isn't applied yet that I can find. Are there any
>> comments on it; can it be applied? Thanks.
>>
>> For reference, it's in patchwork at:
>> http://patchwork.ozlabs.org/patch/134712/
...
>>> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
>>> @@ -62,6 +62,13 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
>>> +#if defined(CONFIG_TEGRA2)
>>> +	/*
>>> +	 * Put a 'D' in the scratchpad to let the kernel know which UART
>>> +	 * for earlyprintk [D]ebugging.
>>> +	 */
>>> +	serial_out('D', &com_port->spr);
>>> +#endif
> 
> I don't like to see such highly architecture specific stuff in common
> code, especially if it's such a dirty hack like this.

Would it help if we moved the this code to some Tegra-specific file
rather than the common serial port driver?

  parent reply	other threads:[~2012-03-13 20:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 22:51 [U-Boot] [PATCH] ns16550: tegra: Specify debugging serial port at boot Stephen Warren
2012-01-10  1:26 ` Doug Anderson
2012-03-08 18:08 ` [U-Boot] " Stephen Warren
2012-03-08 18:39   ` Wolfgang Denk
2012-03-08 19:40     ` Stephen Warren
2012-03-08 21:29       ` Wolfgang Denk
2012-03-08 21:43         ` Stephen Warren
2012-03-08 23:26           ` Graeme Russ
2012-03-13 20:12     ` Stephen Warren [this message]
2012-03-13 21:23       ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5FAA15.7030801@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.