From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()
Date: Wed, 14 Mar 2012 08:27:25 +0100
Message-ID: <4F60485D.9050209@redhat.com>
References: <20120306224330.24264.9494.stgit@dhcp-8-167.nay.redhat.com> <20120306224745.24264.19990.stgit@dhcp-8-167.nay.redhat.com> <4F60455C.7090406@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Amos Kong <akong@redhat.com>, aliguori@us.ibm.com,
	kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com,
	qemu-devel@nongnu.org, laine@redhat.com
To: Orit Wasserman <owasserm@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-we0-f174.google.com ([74.125.82.174]:64186 "EHLO
	mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751562Ab2CNH13 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 14 Mar 2012 03:27:29 -0400
Received: by wejx9 with SMTP id x9so1357716wej.19
        for <kvm@vger.kernel.org>; Wed, 14 Mar 2012 00:27:28 -0700 (PDT)
In-Reply-To: <4F60455C.7090406@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 14/03/2012 08:14, Orit Wasserman ha scritto:
> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)) < 0)
> {	
>     closesocket(*fd);
>     return -socket_error();
> }
> return 0;
> 
> and than you will not need ret

But closesocket could clobber socket_error(), no?

Paolo

From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S7icO-0007z8-GA
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 03:27:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S7icM-0006U2-Ux
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 03:27:32 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:37067)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S7icM-0006Tn-LV
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 03:27:30 -0400
Received: by wibhm17 with SMTP id hm17so5732067wib.4
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 00:27:28 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F60485D.9050209@redhat.com>
Date: Wed, 14 Mar 2012 08:27:25 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20120306224330.24264.9494.stgit@dhcp-8-167.nay.redhat.com>
	<20120306224745.24264.19990.stgit@dhcp-8-167.nay.redhat.com>
	<4F60455C.7090406@redhat.com>
In-Reply-To: <4F60455C.7090406@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Orit Wasserman <owasserm@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com, Amos Kong <akong@redhat.com>

Il 14/03/2012 08:14, Orit Wasserman ha scritto:
> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)) < 0)
> {	
>     closesocket(*fd);
>     return -socket_error();
> }
> return 0;
> 
> and than you will not need ret

But closesocket could clobber socket_error(), no?

Paolo