From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7lt6-0002DZ-VJ for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:57:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7lsh-0003PX-NY for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:57:00 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51774 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7lsh-0003PM-HU for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:56:35 -0400 Message-ID: <4F607961.2000509@suse.de> Date: Wed, 14 Mar 2012 11:56:33 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1330893156-26569-1-git-send-email-afaerber@suse.de> <1331689198-11076-1-git-send-email-afaerber@suse.de> <1331689198-11076-4-git-send-email-afaerber@suse.de> <1331711792.2389.29.camel@epip-laptop> In-Reply-To: <1331711792.2389.29.camel@epip-laptop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/7] target-unicore32: QOM'ify CPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: gxt@mprc.pku.edu.cn Cc: qemu-devel@nongnu.org Am 14.03.2012 08:56, schrieb Guan Xuetao: > On Wed, 2012-03-14 at 02:39 +0100, Andreas F=C3=A4rber wrote: >> Embed CPUUniCore32State into UniCore32CPU. >> >> Contributed under GPLv2+. >> >> Signed-off-by: Andreas F=C3=A4rber >> --- >> Makefile.target | 1 + >> target-unicore32/cpu-qom.h | 72 ++++++++++++++++++++++++++++++++++ >> target-unicore32/cpu.c | 91 +++++++++++++++++++++++++++++++++++= +++++++++ > I hope the gpl information for cpu.c and cpu-qom.h could be consistent > with other files. Copy&paste from other cpu-qom.h files. :) I can change it to match the rest of target-unicore32. But speaking of matching licenses, your previous text has "as published by the Free Software Foundation", which I think is a bit safer in theory (no company X can publish a "GPL" v4 of their own and change it to their liking) and would make the change smaller. For example: * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. + * published by the Free Software Foundation, or (at your option) any + * later version. See the COPYING file in the top-level directory. What do you think? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg