From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60571)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7pEU-0003Z3-Vn
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 10:31:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7pE8-00079E-Od
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 10:31:18 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37381 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7pE8-000794-I7
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 10:30:56 -0400
Message-ID: <4F60AB9E.5000509@suse.de>
Date: Wed, 14 Mar 2012 15:30:54 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331663547-30041-1-git-send-email-mark.langsdorf@calxeda.com>
	<4F5F981B.3010807@suse.de> <m3ipi7hatl.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3ipi7hatl.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Mark Langsdorf <mark.langsdorf@calxeda.com>
Cc: Joshua Housh <joshua.housh@calxeda.com>, aliguori@us.ibm.com, qemu-devel@nongnu.org, paul@codesourcery.com

Am 14.03.2012 08:59, schrieb Markus Armbruster:
> Andreas F=C3=A4rber <afaerber@suse.de> writes:
>=20
>> Am 13.03.2012 19:32, schrieb Mark Langsdorf:
>>> From: Joshua Housh <joshua.housh@calxeda.com>
>>>
>>> Make sure a BusInfo exists before trying to dereference it.
>>
>> What's the use case that breaks?
>=20
> Valid question.
>=20
> Every qdev has / used to have a parent bus, and every bus info.  If
> that's not true anymore, it would be nice to have the commit message
> point to the commit that broke it.

My guess would be a direct usage of QOM TYPE_DEVICE, something I've
tried to avoid in the CPU series so far... there's likely more things
that need changing then.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg