From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33197)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7t1F-0004XK-24
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 14:33:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7t19-0004KG-8K
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 14:33:52 -0400
Received: from cantor2.suse.de ([195.135.220.15]:53522 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7t19-0004K3-20
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 14:33:47 -0400
Message-ID: <4F60E489.3000707@suse.de>
Date: Wed, 14 Mar 2012 19:33:45 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-15-git-send-email-afaerber@suse.de>
	<CAFEAcA-JmkuFURijdEU6Y-Ueusf56CMvVF3ggUe9Fz2U5KJOQw@mail.gmail.com>
In-Reply-To: <CAFEAcA-JmkuFURijdEU6Y-Ueusf56CMvVF3ggUe9Fz2U5KJOQw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC v4 14/44] target-arm: Don't overuse
	CPUState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

Am 14.03.2012 15:39, schrieb Peter Maydell:
> On 10 March 2012 02:27, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Scripted conversion:
>>  sed -i "s/CPUState/CPUARMState/g" target-arm/*.[hc]
>>  sed -i "s/#define CPUARMState/#define CPUState/" target-arm/cpu.h
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> Some of these automated changes in iwmmxt_helper.c break the
> neatly lined up '\' macro continuation characters...
> I'm not sure I care enough to suggest that we should manually fix
> this though, especially not for the ones which are full of hard
> coded tabs.
>=20
> Acked-by: Peter Maydell <peter.maydell@linaro.org>

I didn't check every line of these automated conversions - breaking
alignment, overflowing 80 chars and not fixing
whitespace/braces/indentation on the modified lines are therefore quite
possible.

I'd rather not hack such fixes into this patch wrt rebasing but would
suggest to allow trivial cleanup patches where sensible afterwards.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg