From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41844)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7v04-00079F-Qi
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:40:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7v03-0000PV-2J
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:40:48 -0400
Received: from mail-gy0-f173.google.com ([209.85.160.173]:59001)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7v02-0000PI-UP
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:40:46 -0400
Received: by ghrr14 with SMTP id r14so2605107ghr.4
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 13:40:45 -0700 (PDT)
Message-ID: <4F610248.2060601@codemonkey.ws>
Date: Wed, 14 Mar 2012 15:40:40 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-45-git-send-email-afaerber@suse.de>
	<4F5DC41F.10903@redhat.com> <4F5F39DD.5040308@suse.de>
	<4F61017F.5020301@gmail.com> <4F610179.1000004@suse.de>
In-Reply-To: <4F610179.1000004@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: i.mitsyanko@samsung.com, Igor Mitsyanko <i.mitsyanko@gmail.com>, qemu-devel@nongnu.org, d.solodkiy@samsung.com, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

On 03/14/2012 03:37 PM, Andreas Färber wrote:
> Am 14.03.2012 21:37, schrieb Igor Mitsyanko:
>> On 13.03.2012 3:13 PM, Andreas Färber wrote:
>>
>>> I never heard anyone wanting to generalize reset so far. I don't think
>>> it belongs into Object at least. Maybe DeviceState. Anthony? Paolo?
>>>
>>
>> We can have a special object for this, let's call it ResetLine for
>> example, with methods ResetLine::connect, ResetLine::assert or something
>> like that. Different ResetLine objects could trigger reset of different
>> sets of subdevices, just like real hardware can have several reset types
>> (for example, STM32 has 3 different reset types).
>
> Anthony provided a Reviewed-by, and given that this is a direct
> conversion of cpu_reset() ->  cpu_state_reset() ->  CPUState::reset(), I
> am preparing a PULL for this series tonight. That does not mean that the
> code must stay like this forever. :)
>
> cpu_reset() only handles the full reset of one CPU, as I understand, and
> is called both at startup and at machine-level reset.
>
> Anthony's Pin object, as qemu_irq successor, was planned post-4th QOM
> series, I believe. -- "Small steps, Allie."

Ack.

Regards,

Anthony Liguori

>
> Andreas
>