From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH 09/10] drm/exynos: add G2D driver Date: Thu, 15 Mar 2012 20:05:49 +0900 Message-ID: <4F61CD0D.60601@samsung.com> References: <1331650024-10578-1-git-send-email-inki.dae@samsung.com> <1331650024-10578-10-git-send-email-inki.dae@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id BB4B59ED90 for ; Thu, 15 Mar 2012 04:05:52 -0700 (PDT) Received: from epcpsbgm1.samsung.com (mailout4.samsung.com [203.254.224.34]) by mailout4.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0M0X00K4SATL2R01@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 15 Mar 2012 20:05:51 +0900 (KST) Received: from [165.213.219.123] by mmp1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTPA id <0M0X002VRATRKB20@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 15 Mar 2012 20:05:51 +0900 (KST) In-reply-to: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: Inki Dae , kyungmin.park@samsung.com, sw0312.kim@samsung.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 03/15/2012 07:50 PM, Dave Airlie wrote: >> G2D is a 2D graphic accelerator that supports Bit Block Transfer. This >> G2D driver is exynos drm specific and supports only exynos4x12 series. >> user application fills command set in cmdlist and once dma start request >> these cmdlists are parsed and performed by dma. > Where is this block documented or a pointer to the corresponding open > userspace user code? > > Again the ioctls look like they need to be depointered and use __u64. > > It would be nice if you could document how the command stream and engine work. > > How does userspace pass addresses to it? straight or via gem objects? > how does it > stop userspace blt to places it shouldn't etc. > > I'm getting the feeling this accel enabled driver needs a lot more of > a commit message > and lot more documentation on what it can be used for. OK, i will update the more documentation and simple user space program. Thanks.