All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cihula, Joseph" <joseph.cihula@intel.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "Cui, Dexuan" <dexuan.cui@intel.com>,
	"Wang, Shane" <shane.wang@intel.com>,
	"Jiang, Yunhong" <yunhong.jiang@intel.com>,
	"Yang, Xiaowei" <xiaowei.yang@intel.com>,
	"Ke, Liping" <liping.ke@intel.com>, "Li, Xin" <xin.li@intel.com>
Subject: RE: [RFC] fix xen_in_range()
Date: Thu, 23 Apr 2009 18:26:44 -0700	[thread overview]
Message-ID: <4F65016F6CB04E49BFFA15D4F7B798D9988CFA8C@orsmsx506.amr.corp.intel.com> (raw)
In-Reply-To: <C615D676.947F%keir.fraser@eu.citrix.com>

> From: Keir Fraser [mailto:keir.fraser@eu.citrix.com]
> Sent: Thursday, April 23, 2009 12:25 AM
>
> On 23/04/2009 00:53, "Cihula, Joseph" <joseph.cihula@intel.com> wrote:
>
> > Unfortunately, the frametable is only contiguous in the virtual address space,
> > so one can't simply take __pa() of its start and end.  And since it is quite
> > large, iterating through each page to gets its phys addr adds a perceptible
> > delay when that check has to be done for each page of physical memory (as is
> > the case in the only caller, the VT-d routine that maps memory for dom0).  But
> > it also appears that we can't convert the phys addr arguments into their virt
> > addrs to compare with the contiguous frametable range because they will
> > convert to the DIRECTMAP va's instead.
>
> The frametable is allocated in aligned 2MB chunks. So you can check at that
> granularity rather than 4kB.

That made it just a single iteration on a 2GB system, but what fn should be used to convert the va to pa?  __pa() isn't converting this correctly.

Joe

  parent reply	other threads:[~2009-04-24  1:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 23:53 [RFC] fix xen_in_range() Cihula, Joseph
2009-04-23  7:25 ` Keir Fraser
2009-04-23  7:58   ` Jan Beulich
2009-04-24  1:26   ` Cihula, Joseph [this message]
2009-04-24  7:04     ` Jan Beulich
2009-04-24  7:16       ` Keir Fraser
2009-04-24 23:14         ` Qing He
2009-04-24 23:20         ` [PATCH] iommu: fix unused percpu in xen_in_range() Qing He
2009-04-24 23:29       ` RE: [RFC] fix xen_in_range() Cihula, Joseph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F65016F6CB04E49BFFA15D4F7B798D9988CFA8C@orsmsx506.amr.corp.intel.com \
    --to=joseph.cihula@intel.com \
    --cc=dexuan.cui@intel.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=liping.ke@intel.com \
    --cc=shane.wang@intel.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xiaowei.yang@intel.com \
    --cc=xin.li@intel.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.