From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753209Ab2CWBsk (ORCPT ); Thu, 22 Mar 2012 21:48:40 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:52734 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752103Ab2CWBsi (ORCPT ); Thu, 22 Mar 2012 21:48:38 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <4F6BD60F.8040508@jp.fujitsu.com> Date: Fri, 23 Mar 2012 10:46:55 +0900 From: KAMEZAWA Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Konstantin Khlebnikov CC: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Hugh Dickins Subject: Re: [PATCH v6 5/7] mm: remove lru type checks from __isolate_lru_page() References: <20120322214944.27814.42039.stgit@zurg> <20120322215635.27814.30008.stgit@zurg> In-Reply-To: <20120322215635.27814.30008.stgit@zurg> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/03/23 6:56), Konstantin Khlebnikov wrote: > After patch "mm: forbid lumpy-reclaim in shrink_active_list()" we can completely > remove anon/file and active/inactive lru type filters from __isolate_lru_page(), > because isolation for 0-order reclaim always isolates pages from right lru list. > And pages-isolation for lumpy shrink_inactive_list() or memory-compaction anyway > allowed to isolate pages from all evictable lru lists. > > Signed-off-by: Konstantin Khlebnikov > Cc: KAMEZAWA Hiroyuki > Cc: Hugh Dickins > seems reasonable to me. Acked-by: KAMEZAWA Hiroyuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx111.postini.com [74.125.245.111]) by kanga.kvack.org (Postfix) with SMTP id A536B6B0044 for ; Thu, 22 Mar 2012 21:48:35 -0400 (EDT) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id B0C393EE0B5 for ; Fri, 23 Mar 2012 10:48:33 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 82E6545DE50 for ; Fri, 23 Mar 2012 10:48:33 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 6ABA645DD78 for ; Fri, 23 Mar 2012 10:48:33 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 52DD2E08002 for ; Fri, 23 Mar 2012 10:48:33 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.240.81.146]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id F21B31DB803A for ; Fri, 23 Mar 2012 10:48:32 +0900 (JST) Message-ID: <4F6BD60F.8040508@jp.fujitsu.com> Date: Fri, 23 Mar 2012 10:46:55 +0900 From: KAMEZAWA Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH v6 5/7] mm: remove lru type checks from __isolate_lru_page() References: <20120322214944.27814.42039.stgit@zurg> <20120322215635.27814.30008.stgit@zurg> In-Reply-To: <20120322215635.27814.30008.stgit@zurg> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Hugh Dickins (2012/03/23 6:56), Konstantin Khlebnikov wrote: > After patch "mm: forbid lumpy-reclaim in shrink_active_list()" we can completely > remove anon/file and active/inactive lru type filters from __isolate_lru_page(), > because isolation for 0-order reclaim always isolates pages from right lru list. > And pages-isolation for lumpy shrink_inactive_list() or memory-compaction anyway > allowed to isolate pages from all evictable lru lists. > > Signed-off-by: Konstantin Khlebnikov > Cc: KAMEZAWA Hiroyuki > Cc: Hugh Dickins > seems reasonable to me. Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org