fio terse output issue

fio terse output issue

[Vikram Seth]

Hi Jens,

I have seen that using 2.05 version of fio the terse output formatting
has an issue when there is a text description given in the test file.
There is no newline separating the description and the next job stats.
I have pasted the text at the end of this mail with description as
"Standard Performance test".

I tried following patch and it seemed to work. Do you think it is fine
and if you can fix the issue ?

diff --git a/stat.c b/stat.c
index fa9af7c..e72148b 100644
--- a/stat.c
+++ b/stat.c
@@ -786,7 +786,7 @@ static void show_thread_status_terse_v3(struct
thread_stat *ts,

        /* Additional output if description is set */
        if (strlen(ts->description))
-               log_info(";%s", ts->description);
+               log_info(";%s\n", ts->description);
 }

 static void show_thread_status_terse(struct thread_stat *ts,

Thanks,

Vikram.

---- Here's an example of the output ----

3;2.0.5;seqread_4;0;0;15288;7811;1907;2004;0;0;0.000000;0.000000;105;493150;9648.958399;32194.535776;1.00%=115;5.00%=119;10.00%=125;20.00%=145;30.00%=161;40.00%=243;50.00%=394;60.00%=1384;70.00%=1928;80.00%=4896
;90.00%=23680;95.00%=51968;99.00%=154624;99.50%=193536;99.90%=407552;0%=0;0%=0;0%=0;0%=0;0%=0;106;493151;9649.247253;32194.550405;27;737;4.706345%;359.000000;152.666025;0;0;0;0;0;0;0.000000;0.000000;0;0;0.000000
;0.000000;1.00%=0;5.00%=0;10.00%=0;20.00%=0;30.00%=0;40.00%=0;50.00%=0;60.00%=0;70.00%=0;80.00%=0;90.00%=0;95.00%=0;99.00%=0;99.50%=0;99.90%=0;0%=0;0%=0;0%=0;0%=0;0%=0;0;0;0.000000;0.000000;0;0;0.000000%;0.00000
0;0.000000;0.027473%;0.152348%;4362;0;674;100.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;40.74%;12.61%;2.38%;1.15%;16.90%;5.73%;5.81%;3.09%;5.49%;3.90%;1.86%;0.34%;0.00%;0.00%;0.00%;0.0
0%;sda;23780;28049;266;2247;1041324;452100;1493388;61.45%
;Standard Performance
test3;2.0.5;seqread_8;1;0;20160;10250;1251;2014;0;0;0.000000;0.000000;126;395894;10020.626587;23838.754095;1.00%=139;5.00%=177;10.00%=262;20.00%=572;30.00%=1128;40.00%=1784;50.00%=2512;60.0
0%=3760;70.00%=9664;80.00%=16320;90.00%=21888;95.00%=32640;99.00%=103936;99.50%=193536;99.90%=284672;0%=0;0%=0;0%=0;0%=0;0%=0;126;395895;10021.059127;23838.769654;191;796;5.023146%;502.766667;78.667584;0;0;0;0;0
;0;0.000000;0.000000;0;0;0.000000;0.000000;1.00%=0;5.00%=0;10.00%=0;20.00%=0;30.00%=0;40.00%=0;50.00%=0;60.00%=0;70.00%=0;80.00%=0;90.00%=0;95.00%=0;99.00%=0;99.50%=0;99.90%=0;0%=0;0%=0;0%=0;0%=0;0%=0;0;0;0.0000
00;0.000000;0;0;0.000000%;0.000000;0.000000;0.064603%;0.154053%;3975;0;698;100.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;8.45%;9.72%;5.24%;4.44%;15.52%;17.74%;9.40%;17.18%;9.68%;1.59%;
0.83%;0.20%;0.00%;0.00%;0.00%;0.00%;sda;23780;28049;266;2247;1041324;452100;1493388;61.45%
;Standard Performance
test3;2.0.5;seqread_16;2;0;20160;10285;627;2007;0;0;0.000000;0.000000;186;165737;14257.924603;16248.496462;1.00%=286;5.00%=414;10.00%=732;20.00%=1512;30.00%=5024;40.00%=8896;50.00%=11328;60
.00%=13632;70.00%=17280;80.00%=21120;90.00%=29312;95.00%=40192;99.00%=92672;99.50%=116224;99.90%=140288;0%=0;0%=0;0%=0;0%=0;0%=0;186;165738;14258.525397;16248.474350;462;521;5.013275%;503.533333;15.589508;0;0;0;
0;0;0;0.000000;0.000000;0;0;0.000000;0.000000;1.00%=0;5.00%=0;10.00%=0;20.00%=0;30.00%=0;40.00%=0;50.00%=0;60.00%=0;70.00%=0;80.00%=0;90.00%=0;95.00%=0;99.00%=0;99.50%=0;99.90%=0;0%=0;0%=0;0%=0;0%=0;0%=0;0;0;0.0
00000;0.000000;0;0;0.000000%;0.000000;0.000000;0.084818%;0.127226%;2832;0;734;100.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.0%;0.00%;0.00%;0.00%;0.00%;0.00%;0.00%;0.71%;6.03%;3.49%;3.49%;10.56%;3.89%;16.75%;30.63%;21.67%;2.
06%;0.71%;0.00%;0.00%;0.00%;0.00%;0.00%;sda;23780;28049;266;2247;1041324;452100;1493388;61.45%

Re: fio terse output issue

[Jens Axboe]

On 03/23/2012 01:47 AM, Vikram Seth wrote:
> Hi Jens,
> 
> I have seen that using 2.05 version of fio the terse output formatting
> has an issue when there is a text description given in the test file.
> There is no newline separating the description and the next job stats.
> I have pasted the text at the end of this mail with description as
> "Standard Performance test".
> 
> I tried following patch and it seemed to work. Do you think it is fine
> and if you can fix the issue ?

I think it looks fine, I will apply it. Thanks!

-- 
Jens Axboe

Re: fio terse output issue

[Steven Lang]

Wouldn't it be better to just move the final log_info("\n"); to the
end of the function?  With that patch, it would print the normal line,
then a new line with just ";description" on it.

On Fri, Mar 23, 2012 at 12:02 AM, Jens Axboe <axboe@kernel.dk> wrote:
> On 03/23/2012 01:47 AM, Vikram Seth wrote:
>> Hi Jens,
>>
>> I have seen that using 2.05 version of fio the terse output formatting
>> has an issue when there is a text description given in the test file.
>> There is no newline separating the description and the next job stats.
>> I have pasted the text at the end of this mail with description as
>> "Standard Performance test".
>>
>> I tried following patch and it seemed to work. Do you think it is fine
>> and if you can fix the issue ?
>
> I think it looks fine, I will apply it. Thanks!
>
> --
> Jens Axboe
>
> --
> To unsubscribe from this list: send the line "unsubscribe fio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at �http://vger.kernel.org/majordomo-info.html

Re: fio terse output issue

[Jens Axboe]

On 2012-03-23 17:07, Steven Lang wrote:
> Wouldn't it be better to just move the final log_info("\n"); to the
> end of the function?  With that patch, it would print the normal line,
> then a new line with just ";description" on it.

Yes good point, when I looked at the v2 output, I realized this too.
I'll fix that up. Thanks.

-- 
Jens Axboe