From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghavendra K T Subject: Re: [PATCH 2/2] QEMU kvm: Add support to get/set vcpu unhalt msr to aid migration Date: Fri, 23 Mar 2012 15:08:17 +0530 Message-ID: <4F6C4489.6050003@linux.vnet.ibm.com> References: <20120323082242.17193.16289.sendpatchset@codeblue> <20120323082353.17193.46145.sendpatchset@codeblue> <4F6C3AF8.5050802@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , Alexander Graf , Qemu-devel , KVM , Anthony Liguori , Srivatsa Vaddagiri To: Jan Kiszka Return-path: Received: from e23smtp09.au.ibm.com ([202.81.31.142]:34405 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756542Ab2CWJiq (ORCPT ); Fri, 23 Mar 2012 05:38:46 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Mar 2012 10:28:51 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2N9Wd0B3047518 for ; Fri, 23 Mar 2012 20:32:39 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2N9ceXE002232 for ; Fri, 23 Mar 2012 20:38:41 +1100 In-Reply-To: <4F6C3AF8.5050802@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/23/2012 02:27 PM, Jan Kiszka wrote: > On 2012-03-23 09:23, Raghavendra K T wrote: >> From: Raghavendra K T >> >> MSR_KVM_PV_UNHALT tells whether vcpu is unhalted, which needs to be >> used during migration. > > Err, and where is it actually saved to/restored from the vmstate? You > are lacking an extension of the CPU vmstate, preferably via a substate. > See e.g. cpu/async_pf_msr. > Thanks Jan for review, I 'll check that. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58110) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB0xf-0000fG-CD for qemu-devel@nongnu.org; Fri, 23 Mar 2012 05:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SB0xd-00072K-Oz for qemu-devel@nongnu.org; Fri, 23 Mar 2012 05:39:06 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:44125) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB0xd-00071a-7A for qemu-devel@nongnu.org; Fri, 23 Mar 2012 05:39:05 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Mar 2012 09:21:32 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2N9Wdjf3457236 for ; Fri, 23 Mar 2012 20:32:39 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2N9ceX4002232 for ; Fri, 23 Mar 2012 20:38:40 +1100 Message-ID: <4F6C4489.6050003@linux.vnet.ibm.com> Date: Fri, 23 Mar 2012 15:08:17 +0530 From: Raghavendra K T MIME-Version: 1.0 References: <20120323082242.17193.16289.sendpatchset@codeblue> <20120323082353.17193.46145.sendpatchset@codeblue> <4F6C3AF8.5050802@siemens.com> In-Reply-To: <4F6C3AF8.5050802@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] QEMU kvm: Add support to get/set vcpu unhalt msr to aid migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , KVM , Marcelo Tosatti , Qemu-devel , Alexander Graf , Avi Kivity , Srivatsa Vaddagiri On 03/23/2012 02:27 PM, Jan Kiszka wrote: > On 2012-03-23 09:23, Raghavendra K T wrote: >> From: Raghavendra K T >> >> MSR_KVM_PV_UNHALT tells whether vcpu is unhalted, which needs to be >> used during migration. > > Err, and where is it actually saved to/restored from the vmstate? You > are lacking an extension of the CPU vmstate, preferably via a substate. > See e.g. cpu/async_pf_msr. > Thanks Jan for review, I 'll check that.