From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC96S-0001cL-Qo for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SC96M-0004qz-Ky for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:32:52 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:39906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC96M-0004qc-GD for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:32:46 -0400 Message-ID: <4F7061F4.8000901@citrix.com> Date: Mon, 26 Mar 2012 13:32:52 +0100 From: Julien Grall MIME-Version: 1.0 References: <2187e535bf91f5f650401a4e08e0e795003ad2aa.1332430810.git.julien.grall@citrix.com> <4F6C3FD9020000780007A717@nat28.tlf.novell.com> In-Reply-To: <4F6C3FD9020000780007A717@nat28.tlf.novell.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Beulich Cc: "qemu-devel@nongnu.org" , xen-devel , Julian Pidancet , Stefano Stabellini On 03/23/2012 08:18 AM, Jan Beulich wrote: >> +#define HVMOP_register_pcidev 24 >> +struct xen_hvm_register_pcidev { >> + domid_t domid; /* IN - domain to be serviced */ >> + servid_t id; /* IN - handle from HVMOP_register_ioreq_server */ >> + uint16_t bdf; /* IN - pci */ >> > Can we please avoid the mistake of again not surfacing the PCI > segment in interface definitions, even if it may be required to be > zero for the immediate needs? > What do you hear by surfacing the PCI segment ? Do I need to add the PCI domain ?