From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server Date: Mon, 26 Mar 2012 13:32:52 +0100 Message-ID: <4F7061F4.8000901__17100.4109005027$1332765286$gmane$org@citrix.com> References: <2187e535bf91f5f650401a4e08e0e795003ad2aa.1332430810.git.julien.grall@citrix.com> <4F6C3FD9020000780007A717@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F6C3FD9020000780007A717@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: "qemu-devel@nongnu.org" , xen-devel , Julian Pidancet , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 03/23/2012 08:18 AM, Jan Beulich wrote: >> +#define HVMOP_register_pcidev 24 >> +struct xen_hvm_register_pcidev { >> + domid_t domid; /* IN - domain to be serviced */ >> + servid_t id; /* IN - handle from HVMOP_register_ioreq_server */ >> + uint16_t bdf; /* IN - pci */ >> > Can we please avoid the mistake of again not surfacing the PCI > segment in interface definitions, even if it may be required to be > zero for the immediate needs? > What do you hear by surfacing the PCI segment ? Do I need to add the PCI domain ?