From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC9kG-00081F-7g for qemu-devel@nongnu.org; Mon, 26 Mar 2012 09:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SC9kA-00024M-36 for qemu-devel@nongnu.org; Mon, 26 Mar 2012 09:13:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC9k9-000244-R5 for qemu-devel@nongnu.org; Mon, 26 Mar 2012 09:13:54 -0400 Message-ID: <4F706B86.8040503@redhat.com> Date: Mon, 26 Mar 2012 15:13:42 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4F6B6508.7080205@web.de> <4F6C91E5.2030507@citrix.com> <4F6CA6C0.30701@web.de> <4F6EF6F6.4050603@redhat.com> <4F704CAB.6080309@redhat.com> <4F7051FB.8040501@citrix.com> In-Reply-To: <4F7051FB.8040501@citrix.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [QEMU][RFC PATCH 3/6] memory: Add xen memory hook List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Julien Grall Cc: "xen-devel@lists.xensource.com" , Jan Kiszka , Julian Pidancet , Stefano Stabellini , "qemu-devel@nongnu.org" On 03/26/2012 01:24 PM, Julien Grall wrote: >>> It looks like there are quite a few register_ioport_read/write left >>> around, especially in the following files: >>> >>> hw/acpi_piix4.c >>> hw/cirrus_vga.c >>> hw/serial.c >>> hw/pckbd.c >>> hw/pc.c >>> >>> I guess they should all be converted to memory_region_init_io, right? >>> >> Right > I will modify theses files and send a different patch series. > Great. Please post them as a separate series, they can go in relatively quickly since they should be mostly straighforward. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [QEMU][RFC PATCH 3/6] memory: Add xen memory hook Date: Mon, 26 Mar 2012 15:13:42 +0200 Message-ID: <4F706B86.8040503@redhat.com> References: <4F6B6508.7080205@web.de> <4F6C91E5.2030507@citrix.com> <4F6CA6C0.30701@web.de> <4F6EF6F6.4050603@redhat.com> <4F704CAB.6080309@redhat.com> <4F7051FB.8040501@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F7051FB.8040501@citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Julien Grall Cc: "xen-devel@lists.xensource.com" , Jan Kiszka , Julian Pidancet , Stefano Stabellini , "qemu-devel@nongnu.org" List-Id: xen-devel@lists.xenproject.org On 03/26/2012 01:24 PM, Julien Grall wrote: >>> It looks like there are quite a few register_ioport_read/write left >>> around, especially in the following files: >>> >>> hw/acpi_piix4.c >>> hw/cirrus_vga.c >>> hw/serial.c >>> hw/pckbd.c >>> hw/pc.c >>> >>> I guess they should all be converted to memory_region_init_io, right? >>> >> Right > I will modify theses files and send a different patch series. > Great. Please post them as a separate series, they can go in relatively quickly since they should be mostly straighforward. -- error compiling committee.c: too many arguments to function