From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCFDv-0002ov-Nd for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCFDt-0000uV-VL for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:04:59 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:62711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCFDt-0000uB-RC for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:04:57 -0400 Received: by ghrr14 with SMTP id r14so5073992ghr.4 for ; Mon, 26 Mar 2012 12:04:56 -0700 (PDT) Message-ID: <4F70BDD5.6070007@codemonkey.ws> Date: Mon, 26 Mar 2012 14:04:53 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4F6F1C32.7090801@codemonkey.ws> <4F6F1ED2.6090301@redhat.com> <4F6F2D7D.70500@codemonkey.ws> <4F6F2FB4.5060405@redhat.com> <4F6F32B8.7050401@codemonkey.ws> <4F6F36C7.8010206@redhat.com> <4F6F3941.6040800@codemonkey.ws> <20120326112430.GA150306@orkuz.home> <4F705A09.5070601@redhat.com> <20120326120321.GO22368@redhat.com> <20120326161423.GP9375@otherpad.lan.raisama.net> In-Reply-To: <20120326161423.GP9375@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, Avi Kivity , Gleb Natapov , qemu-devel@nongnu.org On 03/26/2012 11:14 AM, Eduardo Habkost wrote: > On Mon, Mar 26, 2012 at 02:03:21PM +0200, Gleb Natapov wrote: >> On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote: >>> On 03/26/2012 01:24 PM, Jiri Denemark wrote: >>>> ... >>>>>> The command line becomes unstable if you use -nodefconfig. >>>>> >>>>> -no-user-config solves this but I fully expect libvirt would continue to use >>>>> -nodefconfig. >>>> >>>> Libvirt uses -nodefaults -nodefconfig because it wants to fully control how >>>> the virtual machine will look like (mainly in terms of devices). In other >>>> words, we don't want any devices to just magically appear without libvirt >>>> knowing about them. -nodefaults gets rid of default devices that are built >>>> directly in qemu. Since users can set any devices or command line options >>>> (such as enable-kvm) into qemu configuration files in @SYSCONFDIR@, we need to >>>> avoid reading those files as well. Hence we use -nodefconfig. However, we >>>> would still like qemu to read CPU definitions, machine types, etc. once they >>>> become externally loaded configuration (or however we decide to call it). That >>>> said, when CPU definitions are moved into @DATADIR@, and -no-user-config is >>>> introduced, I don't see any reason for libvirt to keep using -nodefconfig. > > ACK. > >>>> >>>> I actually like >>>> -no-user-config >>>> more than >>>> -nodefconfig -readconfig @DATADIR@/... >>>> since it would avoid additional magic to detect what files libvirt should >>>> explicitly pass to -readconfig but basically any approach that would allow us >>>> to do read files only from @DATADIR@ is much better than what we have with >>>> -nodefconfig now. >>> >>> That's how I see it as well. >>> >> +1 >> >> except that instead of -no-user-config we can do what most other >> programs do. If config file is specified during invocation default one >> is not used. After implementing -no-user-config (or similar) we can drop >> -nodefconfig entirely since its only user will be gone it its semantics >> is not clear. > > Awesome. It looks like we have a solution now? Anthony, do you agree > with that? Daniel, it looks good for you? We cannot and should not drop -nodefconfig. But yes, I agree that we should introduce -no-user-config and use the semantics I specified earlier in the thread. Regards, Anthony Liguori