From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCFqO-0003k0-5Y for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:44:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCFqM-0005JA-7u for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:44:43 -0400 Received: from fmmailgate04.web.de ([217.72.192.242]:59642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCFqL-0005J2-UW for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:44:42 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate04.web.de (Postfix) with ESMTP id 7018274304EC for ; Mon, 26 Mar 2012 21:44:40 +0200 (CEST) Message-ID: <4F70C726.9020504@web.de> Date: Mon, 26 Mar 2012 21:44:38 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1332727608-26523-1-git-send-email-liwp@linux.vnet.ibm.com> <4F705F08.4010002@siemens.com> <4F70A877.3060809@codemonkey.ws> <4F70C3E0.4000708@web.de> <4F70C4F6.8090900@codemonkey.ws> <4F70C55D.4030203@web.de> <4F70C5FA.4060605@codemonkey.ws> In-Reply-To: <4F70C5FA.4060605@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4846F22F675B990ADE2929BB" Subject: Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Gavin Shan , "qemu-devel@nongnu.org" , Isaku Yamahata , Avi Kivity , Paolo Bonzini , Wanpeng Li This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4846F22F675B990ADE2929BB Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-03-26 21:39, Anthony Liguori wrote: > On 03/26/2012 02:37 PM, Jan Kiszka wrote: >> On 2012-03-26 21:35, Anthony Liguori wrote: >>>>> Since this is an easily refactorable thing to look at later, I thin= k >>>>> we should >>>>> start with extracting the types. >>>> >>>> My worry is that those three refactorings set bad examples for other= s. >>>> So I'd like to avoid such back and forth if possible. >>> >>> I'm not really worried about it. It's so easier to refactor this >>> later. Why rush it now? >> >> You rush changing the current layout, not me. :) >=20 > No, I'm trying to do incremental changes without boiling the ocean in > the process. >=20 > I think we all are in violent agreement about where we want to end up > (as opaque types as possible). I don't want to hold back additional > refactoring on doing this right (and it's not just a matter of > malloc/free). Either I'm missing it in the code shuffling, or it's not part of this series: Can you point out where more that a forward reference and malloc/free is needed? Jan --------------enig4846F22F675B990ADE2929BB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk9wxyYACgkQitSsb3rl5xRhSgCcDV7bKjk8T8Rs1bTa9/1m8kbP FyoAnjbo2/QmEUc1y3F/KK0Pq8L3IkdP =HJVc -----END PGP SIGNATURE----- --------------enig4846F22F675B990ADE2929BB--