From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v7 08/12] ARM: KVM: World-switch implementation Date: Thu, 29 Mar 2012 12:49:57 +0200 Message-ID: <4F743E55.7020208@redhat.com> References: <20120312065134.8074.36949.stgit@ubuntu> <20120312065241.8074.44277.stgit@ubuntu> <87wr6c88s3.fsf@rustcorp.com.au> <4F730CB3.6010402@redhat.com> <87pqbwz8vy.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Rusty Russell , Christoffer Dall , android-virt@lists.cs.columbia.edu, kvm@vger.kernel.org, Peter Maydell , tech@virtualopensystems.com To: Rusty Russell Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52467 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758654Ab2C2KuM (ORCPT ); Thu, 29 Mar 2012 06:50:12 -0400 In-Reply-To: <87pqbwz8vy.fsf@rustcorp.com.au> Sender: kvm-owner@vger.kernel.org List-ID: On 03/28/2012 11:57 PM, Rusty Russell wrote: > > > > > > Should this code be dropped altogether? Peter points out that once we > > > add new regs, they *must* be initialized to correct reset values in case > > > older QEMU knows nothing about them, but for the rest it just seems > > > confusing... > > > > > > > It's best to initialize everything. As far as this code is concerned > > qemu is just another user and we shouldn't rely on its implementation. > > In which case, qemu should not initialize anything, but read the > registers from the kernel to start with. qemu has its own set of considerations. For example, it needs to initialize registers in tcg mode. But that's another discussion. -- error compiling committee.c: too many arguments to function