From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759978Ab2C2S3G (ORCPT <rfc822;w@1wt.eu>);
	Thu, 29 Mar 2012 14:29:06 -0400
Received: from terminus.zytor.com ([198.137.202.10]:38792 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758064Ab2C2S27 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 29 Mar 2012 14:28:59 -0400
Message-ID: <4F74A9D8.1040808@zytor.com>
Date: Thu, 29 Mar 2012 11:28:40 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1
MIME-Version: 1.0
To: Borislav Petkov <bp@alien8.de>, Matt Fleming <matt.fleming@intel.com>,
        Trevor Turner <turn3r.tr3v0r@gmail.com>,
        Randy Dunlap <rdunlap@xenotime.net>, linux-kernel@vger.kernel.org,
        Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: K7/Athlon Optimization Causes Build Fail on Kernel 3.3 i686
References: <CANYHJ6jjuO7yV_kbPsnJ6X+KXrsz2PRPPXHN4Rkr-vgoSG-E4A@mail.gmail.com> <20120328111957.GA6765@x1.osrc.amd.com> <CANYHJ6j6cxz47TGk8kdU58eau17Fi1K=fH2icmd=v19VjNggKw@mail.gmail.com> <20120328171059.GA7919@x1.osrc.amd.com> <4F7346BB.9020907@xenotime.net> <20120328172759.GC6765@x1.osrc.amd.com> <20120329074802.GA31955@liondog.tnic> <1333008855.4289.3.camel@mfleming-mobl1.ger.corp.intel.com> <20120329104822.GA17233@x1.osrc.amd.com>
In-Reply-To: <20120329104822.GA17233@x1.osrc.amd.com>
X-Enigmail-Version: 1.3.5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03/29/2012 03:48 AM, Borislav Petkov wrote:
> On Thu, Mar 29, 2012 at 09:14:15AM +0100, Matt Fleming wrote:
>> Hmm... I think what might make more sense is to make EFI (not EFI_STUB)
>> depend on !MK7, since I doubt people actually need both MK7 and any EFI
>> firmware support.
> 
> ... and EFI_STUB depends on EFI, yeah, true story.
> 
> Here's an updated patch, Trevor pls try this one instead, thanks.
> 

I like this one for urgent as a quick fix, but it doesn't solve the real
problem which is that boot/compressed shouldn't pick up these macros at all.

It should be possible to build with MK7 (which is an optimization
option) and EFI (a functionality option) since they don't inherently
conflict.  It just doesn't necessarily have to happen *right now*.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.