From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755728Ab2C3XzJ (ORCPT ); Fri, 30 Mar 2012 19:55:09 -0400 Received: from masquerade.micron.com ([137.201.242.130]:47853 "EHLO masquerade.micron.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511Ab2C3XzG (ORCPT ); Fri, 30 Mar 2012 19:55:06 -0400 From: "Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]" To: Ren Mingxin CC: Jens Axboe , "Michael S. Tsirkin" , Rusty Russell , Tejun Heo , LKML , SCSI , KVM , VIRTUAL Subject: Re: [PATCH 3/4] block: replace rssd_disk_name_format() to disk_name_format() Thread-Topic: [PATCH 3/4] block: replace rssd_disk_name_format() to disk_name_format() Thread-Index: AQHNDlr4t9IsT32K8UyBqG6eXi4OGZaDcyEA Date: Fri, 30 Mar 2012 23:54:12 +0000 Message-ID: <4F764778.1030406@micron.com> References: <4F7581D4.4040301@cn.fujitsu.com> <4F758297.5020600@cn.fujitsu.com> In-Reply-To: <4F758297.5020600@cn.fujitsu.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 x-ms-exchange-imapappendstamp: NTXBOICAS03.micron.com (14.01.0355.001) x-originating-ip: [137.201.88.182] x-tm-as-product-ver: SMEX-10.0.0.4152-6.500.1024-18808.001 x-tm-as-result: No--25.989500-0.000000-31 x-tm-as-user-approved-sender: Yes x-tm-as-user-blocked-sender: No x-mt-checkinternalsenderrule: True Content-Type: text/plain; charset="utf-8" Content-ID: <1E778E757F563B4A8AC9502D61A5B220@exchange> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q2UNtIaa020591 On 3/30/2012 2:53 AM, Ren Mingxin wrote: > Currently, block core has been supplied "disk_name_format()", so > we should remove duplicate function "rssd_disk_name_format()" > and use the new function to format rssd disk names. > > Signed-off-by: Ren Mingxin > --- > mtip32xx.c | 33 +-------------------------------- > 1 file changed, 1 insertion(+), 32 deletions(-) Looks fine. Should the subject be "mtip32xx: ..." instead of "block: ..."? I understand "block:" as relating to block core. I am fairly new here. If "block:" can be used for block drivers too, that is fine too. -- Regards, Asai Thambi {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Asai Thambi Samymuthu Pattrayasamy (asamymuthupa) [CONT - Type 2]" Subject: Re: [PATCH 3/4] block: replace rssd_disk_name_format() to disk_name_format() Date: Fri, 30 Mar 2012 23:54:12 +0000 Message-ID: <4F764778.1030406@micron.com> References: <4F7581D4.4040301@cn.fujitsu.com> <4F758297.5020600@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4F758297.5020600@cn.fujitsu.com> Content-Language: en-US Content-ID: <1E778E757F563B4A8AC9502D61A5B220@exchange> Sender: linux-kernel-owner@vger.kernel.org To: Ren Mingxin Cc: Jens Axboe , "Michael S. Tsirkin" , Rusty Russell , Tejun Heo , LKML , SCSI , KVM , VIRTUAL List-Id: linux-scsi@vger.kernel.org T24gMy8zMC8yMDEyIDI6NTMgQU0sIFJlbiBNaW5neGluIHdyb3RlOg0KDQo+ICBDdXJyZW50bHks IGJsb2NrIGNvcmUgaGFzIGJlZW4gc3VwcGxpZWQgImRpc2tfbmFtZV9mb3JtYXQoKSIsIHNvDQo+ IHdlIHNob3VsZCByZW1vdmUgZHVwbGljYXRlIGZ1bmN0aW9uICJyc3NkX2Rpc2tfbmFtZV9mb3Jt YXQoKSINCj4gYW5kIHVzZSB0aGUgbmV3IGZ1bmN0aW9uIHRvIGZvcm1hdCByc3NkIGRpc2sgbmFt ZXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBSZW4gTWluZ3hpbiA8cmVubXhAY24uZnVqaXRzdS5j b20+DQo+IC0tLQ0KPiAgbXRpcDMyeHguYyB8ICAgMzMgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tDQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDMyIGRlbGV0aW9u cygtKQ0KDQoNCkxvb2tzIGZpbmUuDQoNClNob3VsZCB0aGUgc3ViamVjdCBiZSAibXRpcDMyeHg6 IC4uLiIgaW5zdGVhZCBvZiAiYmxvY2s6IC4uLiI/IEkNCnVuZGVyc3RhbmQgImJsb2NrOiIgYXMg cmVsYXRpbmcgdG8gYmxvY2sgY29yZS4gSSBhbSBmYWlybHkgbmV3IGhlcmUuIElmDQoiYmxvY2s6 IiBjYW4gYmUgdXNlZCBmb3IgYmxvY2sgZHJpdmVycyB0b28sIHRoYXQgaXMgZmluZSB0b28uDQoN Ci0tDQpSZWdhcmRzLA0KQXNhaSBUaGFtYmkNCg==