All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Neumann <s.neumann@raumfeld.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Olof Johansson <olof@lixom.net>, Daniel Mack <daniel@caiaq.de>,
	Daniel Mack <zonque@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN
Date: Sat, 07 Apr 2012 20:38:33 +0200	[thread overview]
Message-ID: <4F8089A9.6080704@raumfeld.com> (raw)
In-Reply-To: <20120407070206.GA17623@core.coreip.homeip.net>

Hi,

On 07.04.12 09:02, Dmitry Torokhov wrote:
> On Fri, Apr 06, 2012 at 10:40:07PM -0700, Olof Johansson wrote:
>> This seems to have been broken since 2010, so obviously noone actually
>> cares about the driver:
>>
>> make[4]: *** [drivers/input/touchscreen/eeti_ts.o] Error 1
>> drivers/input/touchscreen/eeti_ts.c: In function 'eeti_ts_irq_active':
>> drivers/input/touchscreen/eeti_ts.c:65:2: error: implicit declaration of function 'irq_to_gpio' [-Werror=implicit-function-declaration]
>>
>> irq_to_gpio isn't available on most platforms today, so the driver
>> will need some rework by someone who has hardware access and can test
>> (to make sure that, for example, switching to level interrupts and just
>> keep taking them while there's more to process works).
>>
>> I guess it could just be scheduled for removal, but let's start with
>> marking it CONFIG_BROKEN.
>
> Well, it probably works quite well on arches that do have irq_to_gpio(),
> let's ask Daniel and Sven if they still have this hardware and if they
> can try the patch below that implements what you suggested.

This hardware is still in use and we also still follow kernel 
development and try to update our customer devices to recent kernel 
versions regularly. Currently we are at 3.1.10 and the touchscreen works 
well with that. I'll try to update to a more recent kernel next week and 
will try your patch.


Regards, Sven


  reply	other threads:[~2012-04-07 18:55 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-07  5:40 [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN Olof Johansson
2012-04-07  7:02 ` Dmitry Torokhov
2012-04-07 18:38   ` Sven Neumann [this message]
2012-04-07 20:32     ` Olof Johansson
2012-04-07 20:32       ` Olof Johansson
2012-04-07 21:04       ` Joachim Eastwood
2012-04-07 21:04         ` Joachim Eastwood
2012-04-07 21:04         ` Joachim Eastwood
2012-04-09  2:28       ` Haojian Zhuang
2012-04-09  2:28         ` Haojian Zhuang
2012-04-10 10:10       ` Russell King - ARM Linux
2012-04-10 10:10         ` Russell King - ARM Linux
2012-04-10 16:01         ` Dmitry Torokhov
2012-04-10 16:01           ` Dmitry Torokhov
2012-05-03  4:36     ` Dmitry Torokhov
2012-07-13  7:01       ` Dmitry Torokhov
2012-07-15 18:21         ` Daniel Mack
2012-07-17 12:59         ` Daniel Mack
2012-07-19 15:36           ` Daniel Mack
2012-07-23 16:51             ` Dmitry Torokhov
2012-07-23 17:58               ` Daniel Mack
2012-07-24 18:01               ` Emulating level IRQs (was: Re: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN) Daniel Mack
2012-07-24 18:58                 ` Mark Brown
2012-08-05 16:22                 ` Emulating level IRQs Daniel Mack
2012-08-05 16:56                   ` Haojian Zhuang
2012-08-05 17:56                     ` Daniel Mack
2012-08-06  1:45                       ` Eric Miao
2012-08-06 16:36                         ` Mark Brown
2012-08-07 15:19                           ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8089A9.6080704@raumfeld.com \
    --to=s.neumann@raumfeld.com \
    --cc=daniel@caiaq.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.