From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 2/2] Xen: Add xen-apic support and hook it up. Date: Wed, 11 Apr 2012 18:13:03 +0200 Message-ID: <4F85AD8F.7000004@siemens.com> References: <1333618350.2513.5.camel@leeds.uk.xensource.com> <1333618505.2513.8.camel@leeds.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Peter Maydell Cc: xen-devel , Wei Liu , "liuw@liuw.name" , Stefano Stabellini , QEMU-devel , Paolo Bonzini List-Id: xen-devel@lists.xenproject.org On 2012-04-11 18:07, Peter Maydell wrote: >> +#include "hw/apic_internal.h" >> +#include "hw/msi.h" >> +#include "xen.h" >> + >> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr, >> + unsigned size) >> +{ >> + return -1U; >> +} > > This seems a rather confusing way to write 'return 0xffffffff;' You mean 0xffffffffffffffff? :) Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux