All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1 0/7] memcg remove pre_destroy
@ 2012-04-12 11:17 KAMEZAWA Hiroyuki
  2012-04-12 11:20   ` KAMEZAWA Hiroyuki
                   ` (10 more replies)
  0 siblings, 11 replies; 67+ messages in thread
From: KAMEZAWA Hiroyuki @ 2012-04-12 11:17 UTC (permalink / raw)
  To: linux-mm
  Cc: cgroups, Michal Hocko, Johannes Weiner, Tejun Heo, Glauber Costa,
	Hugh Dickins, Andrew Morton, KAMEZAWA Hiroyuki

In recent discussion, Tejun Heo, cgroup maintainer, has a plan to remove
->pre_destroy(). And now, in cgroup tree, pre_destroy() failure cause WARNING.

By pre_destroy(), rmdir of cgroup can return -EBUSY or some error.
It makes cgroup complicated and unstable. I said O.K. to remove it and
this patch is modification for memcg.

One of problem in current implementation is that memcg moves all charges to
parent in pre_destroy(). At doing so, if use_hierarchy=0, pre_destroy() may
hit parent's limit and may return -EBUSY. To fix this problem, this patch
changes behavior of rmdir() as

 - if use_hierarchy=0, all remaining charges will go to root cgroup.
 - if use_hierarchy=1, all remaining charges will go to the parent.

By this, rmdir failure will not be caused by parent's limitation. And
I think this meets meaning of use_hierarchy.

This series does
  - add above change of behavior
  - use workqueue to move all pages to parent
  - remove unnecessary codes.

I'm sorry if my reply is delayed, I'm not sure I can have enough time in
this weekend. Any comments are welcomed.

Thanks,
-Kame


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 67+ messages in thread

end of thread, other threads:[~2012-04-18 17:03 UTC | newest]

Thread overview: 67+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-12 11:17 [PATCH v1 0/7] memcg remove pre_destroy KAMEZAWA Hiroyuki
2012-04-12 11:20 ` [PATCH 1/7] res_counter: add a function res_counter_move_parent() KAMEZAWA Hiroyuki
2012-04-12 11:20   ` KAMEZAWA Hiroyuki
2012-04-12 13:22   ` Glauber Costa
2012-04-12 14:30     ` Frederic Weisbecker
2012-04-13  0:57       ` KAMEZAWA Hiroyuki
2012-04-13  0:57         ` KAMEZAWA Hiroyuki
2012-04-13  1:04         ` Frederic Weisbecker
2012-04-13  1:04           ` Frederic Weisbecker
2012-04-13  1:05           ` KAMEZAWA Hiroyuki
2012-04-16 22:19   ` Tejun Heo
2012-04-16 22:19     ` Tejun Heo
2012-04-18  6:59     ` KAMEZAWA Hiroyuki
2012-04-18  6:59       ` KAMEZAWA Hiroyuki
2012-04-16 22:31   ` Tejun Heo
2012-04-18  7:04     ` KAMEZAWA Hiroyuki
2012-04-18  7:04       ` KAMEZAWA Hiroyuki
2012-04-18 17:03       ` Tejun Heo
2012-04-18 17:03         ` Tejun Heo
2012-04-12 11:21 ` [PATCH 2/7] memcg: move charge to parent only when necessary KAMEZAWA Hiroyuki
2012-04-12 11:21   ` KAMEZAWA Hiroyuki
2012-04-16 22:21   ` Tejun Heo
2012-04-16 22:21     ` Tejun Heo
2012-04-18  7:01     ` KAMEZAWA Hiroyuki
2012-04-18  7:01       ` KAMEZAWA Hiroyuki
2012-04-12 11:22 ` [PATCH 3/7] memcg: move charges to root at rmdir() KAMEZAWA Hiroyuki
2012-04-12 11:22   ` KAMEZAWA Hiroyuki
2012-04-16 22:30   ` Tejun Heo
2012-04-16 22:30     ` Tejun Heo
2012-04-18  7:02     ` KAMEZAWA Hiroyuki
2012-04-12 11:24 ` [PATCH 4/7] memcg: remove 'uncharge' argument from mem_cgroup_move_account() KAMEZAWA Hiroyuki
2012-04-12 11:24   ` KAMEZAWA Hiroyuki
2012-04-12 13:27   ` Glauber Costa
2012-04-13  1:01     ` KAMEZAWA Hiroyuki
2012-04-12 11:28 ` [PATCH 5/7] memcg: divide force_empty into 2 functions, avoid memory reclaim at rmdir KAMEZAWA Hiroyuki
2012-04-12 11:28   ` KAMEZAWA Hiroyuki
2012-04-12 13:33   ` Glauber Costa
2012-04-17 17:29   ` Ying Han
2012-04-18  7:14     ` KAMEZAWA Hiroyuki
2012-04-18  7:14       ` KAMEZAWA Hiroyuki
2012-04-12 11:30 ` [PATCH 6/7] memcg: remove pre_destroy() KAMEZAWA Hiroyuki
2012-04-12 11:30   ` KAMEZAWA Hiroyuki
2012-04-16 22:38   ` Tejun Heo
2012-04-18  7:12     ` KAMEZAWA Hiroyuki
2012-04-18  7:12       ` KAMEZAWA Hiroyuki
2012-04-17 17:47   ` Ying Han
2012-04-17 17:47     ` Ying Han
2012-04-12 11:31 ` [PATCH 7/7] memcg: remove drain_all_stock_sync KAMEZAWA Hiroyuki
2012-04-12 11:31   ` KAMEZAWA Hiroyuki
2012-04-12 13:35   ` Glauber Costa
2012-04-12 13:35     ` Glauber Costa
2012-04-12 13:20 ` [PATCH v1 0/7] memcg remove pre_destroy Glauber Costa
2012-04-12 13:20   ` Glauber Costa
2012-04-12 16:06 ` Tejun Heo
2012-04-12 16:06   ` Tejun Heo
2012-04-12 18:57   ` Aneesh Kumar K.V
2012-04-12 18:57     ` Aneesh Kumar K.V
2012-04-12 23:59     ` KAMEZAWA Hiroyuki
2012-04-13  8:50       ` Michal Hocko
2012-04-13  8:50         ` Michal Hocko
2012-04-13 22:19         ` Aneesh Kumar K.V
2012-04-13 22:19           ` Aneesh Kumar K.V
2012-04-16 22:41 ` Tejun Heo
2012-04-16 22:41   ` Tejun Heo
2012-04-17 17:35 ` Ying Han
2012-04-18  7:15   ` KAMEZAWA Hiroyuki
2012-04-18  7:15     ` KAMEZAWA Hiroyuki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.