From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timo Ketola Date: Thu, 12 Apr 2012 16:16:26 +0300 Subject: [U-Boot] [PATCH 5/8] MXC FEC: Resolve speed before configuring gasket In-Reply-To: <4F86C50A.9000001@denx.de> References: <1334223234-23383-1-git-send-email-timo@exertus.fi> <1334223234-23383-6-git-send-email-timo@exertus.fi> <4F86C50A.9000001@denx.de> Message-ID: <4F86D5AA.3050703@exertus.fi> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12.04.2012 15:05, Stefano Babic wrote: > On 12/04/2012 11:33, Timo Ketola wrote: >> Signed-off-by: Timo Ketola >> --- a/drivers/net/fec_mxc.c >> +++ b/drivers/net/fec_mxc.c > > Please consider to rebase your patch on u-boot-imx, next branch. There > are already a couple of patches related to gasket and MII. u-boot-imx is separate repository, right? So I have to clone that and apply my patches manually, right? >> + // FIXME: useless call: miiphy_duplex(edev->name, fec->phy_id); > > This is dead code. // comments are not allowed, comment should be real > comments, not used to disable code. Why are you disabling ? Please > explain the reason and, if it is required, provide a separate patch for > this. Return value is discarded and I didn't find any side effects. So it seems to be dead call. If agreed, then I'll edit the patch. -- Timo