From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, x86@kernel.org,
Giancarlo Asnaghi <giancarlo.asnaghi@st.com>,
Alan Cox <alan@linux.intel.com>,
Alessandro Rubini <rubini@gnudd.com>
Subject: Re: [PATCH V4 1/3] x86: introduce CONFIG_X86_DEV_DMA_OPS
Date: Thu, 12 Apr 2012 11:01:15 -0700 [thread overview]
Message-ID: <4F87186B.9010303@zytor.com> (raw)
In-Reply-To: <20120314065614.GB27480@elte.hu>
On 03/13/2012 11:56 PM, Ingo Molnar wrote:
>
> * Alessandro Rubini <rubini@gnudd.com> wrote:
>
>> 32-bit x86 systems may need their own DMA operations, so add a
>> new config option, which is turned on for 64-bit systems. This
>> patch has no functional effect but it paves the way for
>> supporting the STA2x11 I/O Hub and possibly other chips.
>>
>> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
>> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
>> Cc: Alan Cox <alan@linux.intel.com>
>> ---
>> arch/x86/Kconfig | 5 +++++
>> arch/x86/include/asm/device.h | 4 ++--
>> arch/x86/include/asm/dma-mapping.h | 2 +-
>> 3 files changed, 8 insertions(+), 3 deletions(-)
>
> Ok, the whole series looks pretty clean, modulo a few mostly
> cosmetic details in the driver itself.
>
> Andrew, you are typically merging dma-mapping.h patches, would
> you like to do these, or can we do it in tip:x86/platform?
>
> It would also be nice if the gents on Cc: would voice objections
> or approval, if any.
>
I looked over it, and at least this bit seems okay to me.
Acked-by: H. Peter Anvin <hpa@zytor.com>
Andrew, I guess the question is still open?
I have to express some concern about where this device may be going, though.
-hpa
next prev parent reply other threads:[~2012-04-12 18:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 7:28 [PATCH V4 0/3] *** SUBJECT HERE *** Alessandro Rubini
2012-03-13 7:30 ` [PATCH V4 1/3] x86: introduce CONFIG_X86_DEV_DMA_OPS Alessandro Rubini
2012-03-14 6:56 ` Ingo Molnar
2012-04-12 18:01 ` H. Peter Anvin [this message]
2012-04-12 20:15 ` Alessandro Rubini
2012-04-12 20:18 ` H. Peter Anvin
2012-04-12 20:32 ` Alessandro Rubini
2012-04-12 20:47 ` H. Peter Anvin
2012-04-14 11:38 ` Ingo Molnar
2012-04-11 10:19 ` Alessandro Rubini
2012-03-13 7:30 ` [PATCH V4 2/3] x86: introduce CONFIG_X86_DMA_REMAP Alessandro Rubini
2012-03-13 7:30 ` [PATCH V4 3/3] x86/PCI: initial support for sta2x11 I/O hub Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87186B.9010303@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=giancarlo.asnaghi@st.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rubini@gnudd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.