From: Jan Schmidt <mail@jan-o-sch.net>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Mark Fasheh <mfasheh@suse.de>,
linux-btrfs@vger.kernel.org, Chris Mason <chris.mason@oracle.com>,
Josef Bacik <josef@redhat.com>
Subject: Re: [PATCH 3/3] btrfs: extended inode refs
Date: Thu, 12 Apr 2012 20:38:18 +0200 [thread overview]
Message-ID: <4F87211A.9070905@jan-o-sch.net> (raw)
In-Reply-To: <4F871808.3050309@jan-o-sch.net>
On 12.04.2012 19:59, Jan Schmidt wrote:
>> -static int iterate_irefs(u64 inum, struct btrfs_root *fs_root,
>> - struct btrfs_path *path,
>> - iterate_irefs_t *iterate, void *ctx)
>> +static int iterate_inode_refs(u64 inum, struct btrfs_root *fs_root,
>> + struct btrfs_path *path,
>> + iterate_irefs_t *iterate, void *ctx)
>
> This function must not call free_extent_buffer(eb) in line 1306 after
> applying your patch set (immediately before the break). Second, I think
> we'd better add a blocking read lock on eb after incrementing it's
> refcount, because we need the current content to stay as it is. Both
> isn't part of your patches, but it might be easier if you make that
> bugfix change as a 3/4 patch within your set and turn this one into 4/4.
> If you don't like that, I'll send a separate patch for it. Don't miss
> the unlock if you do it ;-)
FYI: There are more read locks missing in the current version of
backref.c. So I made a bugfix patch myself which I'll test and send
tomorrow.
-Jan
next prev parent reply other threads:[~2012-04-12 18:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 20:09 [PATCH 0/3] " Mark Fasheh
2012-04-05 20:09 ` [PATCH 1/3] " Mark Fasheh
2012-04-12 13:08 ` Jan Schmidt
2012-04-24 22:23 ` Mark Fasheh
2012-04-25 10:19 ` Jan Schmidt
2012-04-05 20:09 ` [PATCH 2/3] " Mark Fasheh
2012-04-12 13:08 ` Jan Schmidt
2012-05-03 23:12 ` Mark Fasheh
2012-05-04 11:39 ` David Sterba
2012-04-12 15:53 ` Jan Schmidt
2012-05-01 18:39 ` Mark Fasheh
2012-04-05 20:09 ` [PATCH 3/3] " Mark Fasheh
2012-04-12 17:59 ` Jan Schmidt
2012-04-12 18:38 ` Jan Schmidt [this message]
2012-05-08 22:57 ` Mark Fasheh
2012-05-09 17:02 ` Chris Mason
2012-05-10 8:23 ` Jan Schmidt
2012-05-10 13:35 ` Chris Mason
2012-04-05 21:13 ` [PATCH 0/3] " Jeff Mahoney
2012-04-11 13:11 ` Jan Schmidt
2012-04-11 13:29 ` Jan Schmidt
2012-04-12 16:11 ` Chris Mason
2012-04-12 16:19 ` Mark Fasheh
2012-04-06 1:24 ` Liu Bo
2012-04-06 2:12 ` Liu Bo
2012-05-21 21:46 Mark Fasheh
2012-05-21 21:46 ` [PATCH 3/3] " Mark Fasheh
2012-07-06 14:57 ` Jan Schmidt
2012-07-09 20:24 ` Mark Fasheh
2012-08-08 18:55 [PATCH 0/3] " Mark Fasheh
2012-08-08 18:55 ` [PATCH 3/3] " Mark Fasheh
2012-08-15 8:46 ` Jan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87211A.9070905@jan-o-sch.net \
--to=mail@jan-o-sch.net \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
--cc=mfasheh@suse.de \
--subject='Re: [PATCH 3/3] btrfs: extended inode refs' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.