All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>, "Balbi, Felipe" <balbi@ti.com>
Cc: "Mohammed, Afzal" <afzal@ti.com>, Greg KH <greg@kroah.com>,
	"Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
	"V, Aneesh" <aneesh@ti.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"mgreer@animalcreek.com" <mgreer@animalcreek.com>,
	"msalter@redhat.com" <msalter@redhat.com>
Subject: Re: [PATCH v4 0/7] Add TI EMIF SDRAM controller driver
Date: Thu, 12 Apr 2012 20:50:55 +0200	[thread overview]
Message-ID: <4F87240F.6060902@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204121053570.29473@utopia.booyaka.com>

+ Felipe,

Hi Paul,

On 4/12/2012 7:00 PM, Paul Walmsley wrote:
> Hi
>
> On Thu, 12 Apr 2012, Mohammed, Afzal wrote:
>
>> On Thu, Apr 12, 2012 at 18:40:45, Greg KH wrote:
>>> On Thu, Apr 12, 2012 at 12:17:49PM +0530, Santosh Shilimkar wrote:
>>>> I was hoping that we will have some thing like drivers/memory/*
>>>> but since it doesn't exist, we used drivers/misc.
>>>
>>> Why not create it?  I have no objection to that, it makes it more
>>> obvious as to what this really is.
>>
>> There is another memory controller used in a few TI SoCs,
>> namely GPMC [1], do you prefer having it too there.
>>
>> As of now it is not a driver, platform code handles GPMC, a patch
>> series for converting it into a driver (but still residing in
>> platform folder) was sent a few days back [2,3].
>
> Probably the GPMC driver should go into a slightly different place than
> SDRC/EMIF.
>
> GPMC is actually a general-purpose parallel bus driver.  It's used to
> interface Ethernet controllers, UARTs, FPGAs, NAND/NOR flash, SRAM, etc.
> It cannot be used to control DRAM, at least not without a separate DRAM
> controller chip.
>
> SDRC/EMIF are both DRAM controllers.  That's all they do.  They can't be
> used to control anything else.  They implement DRAM refresh, etc.

The LPDDR2 spec does consider as well NVM (Non Volatile Memory), so I 
think we should stick to driver/memory for EMIF.

> So perhaps something like drivers/memory/dram/ for the SDRAM controllers,
> and maybe drivers/memory/ for the GPMC?

In fact Felipe was considering something else for that kind of general 
purpose bus driver like GMPC, C2C and LLI...

... But I do not remember the name :-)

Regards,
Benoit

WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 0/7] Add TI EMIF SDRAM controller driver
Date: Thu, 12 Apr 2012 20:50:55 +0200	[thread overview]
Message-ID: <4F87240F.6060902@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1204121053570.29473@utopia.booyaka.com>

+ Felipe,

Hi Paul,

On 4/12/2012 7:00 PM, Paul Walmsley wrote:
> Hi
>
> On Thu, 12 Apr 2012, Mohammed, Afzal wrote:
>
>> On Thu, Apr 12, 2012 at 18:40:45, Greg KH wrote:
>>> On Thu, Apr 12, 2012 at 12:17:49PM +0530, Santosh Shilimkar wrote:
>>>> I was hoping that we will have some thing like drivers/memory/*
>>>> but since it doesn't exist, we used drivers/misc.
>>>
>>> Why not create it?  I have no objection to that, it makes it more
>>> obvious as to what this really is.
>>
>> There is another memory controller used in a few TI SoCs,
>> namely GPMC [1], do you prefer having it too there.
>>
>> As of now it is not a driver, platform code handles GPMC, a patch
>> series for converting it into a driver (but still residing in
>> platform folder) was sent a few days back [2,3].
>
> Probably the GPMC driver should go into a slightly different place than
> SDRC/EMIF.
>
> GPMC is actually a general-purpose parallel bus driver.  It's used to
> interface Ethernet controllers, UARTs, FPGAs, NAND/NOR flash, SRAM, etc.
> It cannot be used to control DRAM, at least not without a separate DRAM
> controller chip.
>
> SDRC/EMIF are both DRAM controllers.  That's all they do.  They can't be
> used to control anything else.  They implement DRAM refresh, etc.

The LPDDR2 spec does consider as well NVM (Non Volatile Memory), so I 
think we should stick to driver/memory for EMIF.

> So perhaps something like drivers/memory/dram/ for the SDRAM controllers,
> and maybe drivers/memory/ for the GPMC?

In fact Felipe was considering something else for that kind of general 
purpose bus driver like GMPC, C2C and LLI...

... But I do not remember the name :-)

Regards,
Benoit

  reply	other threads:[~2012-04-12 18:51 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 21:51 [PATCH v4 0/7] Add TI EMIF SDRAM controller driver Aneesh V
2012-03-16 21:51 ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 1/7] misc: ddr: add LPDDR2 data from JESD209-2 Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 2/7] misc: emif: add register definitions for EMIF Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 3/7] misc: emif: add basic infrastructure for EMIF driver Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 4/7] misc: emif: handle frequency and voltage change events Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 5/7] misc: emif: add interrupt and temperature handling Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 6/7] misc: emif: add one-time settings Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-16 21:51 ` [PATCH v4 7/7] misc: emif: add debugfs entries for emif Aneesh V
2012-03-16 21:51   ` Aneesh V
2012-03-17  6:10 ` [PATCH v4 0/7] Add TI EMIF SDRAM controller driver Kyungmin Park
2012-03-17  6:10   ` Kyungmin Park
2012-03-17  6:10   ` Kyungmin Park
2012-04-12  2:44 ` Paul Walmsley
2012-04-12  2:44   ` Paul Walmsley
2012-04-12  2:57   ` Aneesh V
2012-04-12  2:57     ` Aneesh V
2012-04-12  2:57     ` Aneesh V
2012-04-12  3:00   ` Greg KH
2012-04-12  3:00     ` Greg KH
2012-04-12  3:12     ` Paul Walmsley
2012-04-12  3:12       ` Paul Walmsley
2012-04-12  6:47     ` Santosh Shilimkar
2012-04-12  6:47       ` Santosh Shilimkar
2012-04-12 13:10       ` Greg KH
2012-04-12 13:10         ` Greg KH
2012-04-12 13:34         ` Mohammed, Afzal
2012-04-12 13:34           ` Mohammed, Afzal
2012-04-12 13:34           ` Mohammed, Afzal
2012-04-12 14:10           ` Greg KH
2012-04-12 14:10             ` Greg KH
2012-04-12 14:10             ` Greg KH
2012-04-12 14:15             ` Mohammed, Afzal
2012-04-12 14:15               ` Mohammed, Afzal
2012-04-12 14:15               ` Mohammed, Afzal
2012-04-12 14:21           ` Kevin Hilman
2012-04-12 14:21             ` Kevin Hilman
2012-04-12 14:21             ` Kevin Hilman
2012-04-12 17:00           ` Paul Walmsley
2012-04-12 17:00             ` Paul Walmsley
2012-04-12 17:00             ` Paul Walmsley
2012-04-12 18:50             ` Cousson, Benoit [this message]
2012-04-12 18:50               ` Cousson, Benoit
2012-04-12 18:50               ` Cousson, Benoit
2012-04-12 19:15               ` Paul Walmsley
2012-04-12 19:15                 ` Paul Walmsley
2012-04-12 19:15                 ` Paul Walmsley
2012-04-12 19:24                 ` Cousson, Benoit
2012-04-12 19:24                   ` Cousson, Benoit
2012-04-12 19:24                   ` Cousson, Benoit
2012-04-13  9:07               ` Felipe Balbi
2012-04-13  9:07                 ` Felipe Balbi
2012-04-13  9:07                 ` Felipe Balbi
2012-04-12 14:14         ` Shilimkar, Santosh
2012-04-12 14:14           ` Shilimkar, Santosh
2012-04-12 19:58     ` V, Aneesh
2012-04-12 19:58       ` V, Aneesh
2012-04-23 10:56       ` Mohammed, Afzal
2012-04-23 10:56         ` Mohammed, Afzal
2012-04-23 10:56         ` Mohammed, Afzal
2012-04-23 11:04         ` Shilimkar, Santosh
2012-04-23 11:04           ` Shilimkar, Santosh
2012-04-23 11:04           ` Shilimkar, Santosh
2012-04-23 11:09           ` Mohammed, Afzal
2012-04-23 11:09             ` Mohammed, Afzal
2012-04-23 11:09             ` Mohammed, Afzal
2012-04-23 14:27           ` Greg KH
2012-04-23 14:27             ` Greg KH
2012-04-23 14:27             ` Greg KH
2012-04-23 14:44             ` Shilimkar, Santosh
2012-04-23 14:44               ` Shilimkar, Santosh
2012-04-23 14:44               ` Shilimkar, Santosh
2012-04-27 13:16               ` Santosh Shilimkar
2012-04-27 13:16                 ` Santosh Shilimkar
2012-04-27 13:16                 ` Santosh Shilimkar
2012-04-13 14:15   ` Mark Salter
2012-04-13 14:15     ` Mark Salter
2012-03-19  1:08 함명주
2012-03-19  7:07 ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F87240F.6060902@ti.com \
    --to=b-cousson@ti.com \
    --cc=afzal@ti.com \
    --cc=aneesh@ti.com \
    --cc=balbi@ti.com \
    --cc=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mgreer@animalcreek.com \
    --cc=msalter@redhat.com \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.