From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c Date: Fri, 13 Apr 2012 10:20:48 -0400 Message-ID: <4F883640.60103@pobox.com> References: <1333447938-16461-1-git-send-email-tqnguyen@apm.com> <4F7AE584.3050805@mvista.com> <4F873573.10406@pobox.com> <3445364d6d28c2b6ae19817fe6851452@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f174.google.com ([209.85.216.174]:46933 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753464Ab2DMOUx (ORCPT ); Fri, 13 Apr 2012 10:20:53 -0400 In-Reply-To: <3445364d6d28c2b6ae19817fe6851452@mail.gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Thang Nguyen Cc: Sergei Shtylyov , Benjamin Herrenschmidt , Paul Mackerras , Grant Likely , Rob Herring , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, Phong Vo On 04/13/2012 03:18 AM, Thang Nguyen wrote: > Thanks Jeff and Sergei, > > As your suggestion, I will separate the patch into smaller patches and > support more features on the SATA DWC driver. The patches I intend to do > on the SATA DWC are as below: > - Support hardreset: currently the hardreset is not supported. This > causes sometime the SATA driver does cause kernel crash because of > not-determined state. > - Let device tree specified DMA channel: currently only channel 0 is > supported (number of channel is set to 1). If device tree not specified > DMA channel, channel 0 will be used as default. > - Support ATAPI. > - Remove dma_interrupt_count. for each DMA transfer, we need 2 interrupts > for QC completion: transfer completion and DMA transfer completion > interrupt. The current code wait for both 2 interrupts occur before > calling qc_complete. This will make out-of-sync state when an interrupt > lost or when errors occur. The change will process DMA register when DMA > transfer complete interrupt occur and call qc_issue when command > completion interrupt occur. > - Fix NCQ issue and set .can_queue back to ATA_MAX_QUEUE. > - Support Port Multiplier. > - Support 2 SATA ports on Maui. Sounds good, thanks for splitting up the patch into smaller pieces. The main goal is that separate logical changes should go into separate patches. Jeff From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: Jeff Garzik Message-ID: <4F883640.60103@pobox.com> Date: Fri, 13 Apr 2012 10:20:48 -0400 From: Jeff Garzik MIME-Version: 1.0 To: Thang Nguyen Subject: Re: [PATCH 1/1] Add support 2 SATA ports for Maui and change filename from sata_dwc_460ex.c to sata_dwc_4xx.c References: <1333447938-16461-1-git-send-email-tqnguyen@apm.com> <4F7AE584.3050805@mvista.com> <4F873573.10406@pobox.com> <3445364d6d28c2b6ae19817fe6851452@mail.gmail.com> In-Reply-To: <3445364d6d28c2b6ae19817fe6851452@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Sergei Shtylyov , Phong Vo , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , linux-ide@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 04/13/2012 03:18 AM, Thang Nguyen wrote: > Thanks Jeff and Sergei, > > As your suggestion, I will separate the patch into smaller patches and > support more features on the SATA DWC driver. The patches I intend to do > on the SATA DWC are as below: > - Support hardreset: currently the hardreset is not supported. This > causes sometime the SATA driver does cause kernel crash because of > not-determined state. > - Let device tree specified DMA channel: currently only channel 0 is > supported (number of channel is set to 1). If device tree not specified > DMA channel, channel 0 will be used as default. > - Support ATAPI. > - Remove dma_interrupt_count. for each DMA transfer, we need 2 interrupts > for QC completion: transfer completion and DMA transfer completion > interrupt. The current code wait for both 2 interrupts occur before > calling qc_complete. This will make out-of-sync state when an interrupt > lost or when errors occur. The change will process DMA register when DMA > transfer complete interrupt occur and call qc_issue when command > completion interrupt occur. > - Fix NCQ issue and set .can_queue back to ATA_MAX_QUEUE. > - Support Port Multiplier. > - Support 2 SATA ports on Maui. Sounds good, thanks for splitting up the patch into smaller pieces. The main goal is that separate logical changes should go into separate patches. Jeff