From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q3DHujQU079896 for ; Fri, 13 Apr 2012 12:56:45 -0500 Message-ID: <4F8868DA.7040000@sgi.com> Date: Fri, 13 Apr 2012 12:56:42 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 07/18] xfs: check for buffer errors before waiting References: <1334319061-12968-1-git-send-email-david@fromorbit.com> <1334319061-12968-8-git-send-email-david@fromorbit.com> In-Reply-To: <1334319061-12968-8-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 04/13/12 07:10, Dave Chinner wrote: > From: Dave Chinner > > If we call xfs_buf_iowait() on a buffer that failed dispatch due to > an IO error, it will wait forever for an Io that does not exist. > This is hndled in xfs_buf_read, but there is other code that calls > xfs_buf_iowait directly that doesn't. > > Rather than make the call sites have to handle checking for dispatch > errors and then checking for completion errors, make > xfs_buf_iowait() check for dispatch errors on the buffer before > waiting. This means we handle both dispatch and completion errors > with one set of error handling at the caller sites. > > Signed-off-by: Dave Chinner > Reviewed-by: Christoph Hellwig > --- Looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs