From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [PATCH 00/12] Add more DMT and common modes Date: Fri, 13 Apr 2012 16:56:26 -0400 Message-ID: <4F8892FA.9050807@redhat.com> References: <1334349220-13814-1-git-send-email-ajax@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334349220-13814-1-git-send-email-ajax@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 4/13/12 4:33 PM, Adam Jackson wrote: > Incorporates some feedback from Rodrigo and Takashi. Major themes of the > series: > > - Fix the DMT list to include reduced-blanking modes > - Add modes from DMT for any range descriptor type > - Add an extra modes list for things not in DMT > - For ranges that specify a formula, generate timings from the extra modes > > This still doesn't address the driver policy decision of "I know I have > a scaler, add modes as if there were a range descriptor even if there's > not one". But it should at least make clear what such a helper function > should do. One minor buglet in this series that's not obvious from inspection (and that I didn't realize until just now) is that putting 1366x768 in the minimode list won't do what you want, since the mode you get back will be 1368x768. Probably we should move the manual-underscan hack into the timing generators themselves. - ajax