From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush
Date: Wed, 18 Apr 2012 16:11:38 -0500 [thread overview]
Message-ID: <4F8F2E0A.5020807@sgi.com> (raw)
In-Reply-To: <20120327164646.158577302@bombadil.infradead.org>
On 03/27/12 11:44, Christoph Hellwig wrote:
> Instead of writing the buffer directly from inside xfs_qm_dqflush return it
> to the caller and let the caller decide what to do with the buffer. Also
> remove the pincount check in xfs_qm_dqflush that all non-blocking callers
> already implement and the now unused flags parameter and the XFS_DQ_IS_DIRTY
> check that all callers already perform.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-18 21:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 16:44 [PATCH 00/10] remove xfsbufd Christoph Hellwig
2012-03-27 16:44 ` [PATCH 01/10] xfs: remove log item from AIL in xfs_qm_dqflush after a shutdown Christoph Hellwig
2012-03-27 18:17 ` Mark Tinguely
2012-04-13 9:36 ` Dave Chinner
2012-03-27 16:44 ` [PATCH 02/10] xfs: remove log item from AIL in xfs_iflush " Christoph Hellwig
2012-04-13 9:37 ` Dave Chinner
2012-03-27 16:44 ` [PATCH 03/10] xfs: allow assigning the tail lsn with the AIL lock held Christoph Hellwig
2012-03-27 18:18 ` Mark Tinguely
2012-04-13 9:42 ` Dave Chinner
2012-03-27 16:44 ` [PATCH 04/10] xfs: implement freezing by emptying the AIL Christoph Hellwig
2012-04-13 10:04 ` Dave Chinner
2012-04-16 13:33 ` Mark Tinguely
2012-04-16 13:47 ` Mark Tinguely
2012-04-16 23:54 ` Dave Chinner
2012-04-17 4:20 ` Dave Chinner
2012-04-17 8:26 ` Dave Chinner
2012-04-18 13:13 ` Mark Tinguely
2012-04-18 18:14 ` Ben Myers
2012-04-18 17:53 ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 05/10] xfs: do flush inodes from background inode reclaim Christoph Hellwig
2012-04-13 10:14 ` Dave Chinner
2012-04-16 19:25 ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 06/10] xfs: do not write the buffer from xfs_iflush Christoph Hellwig
2012-04-13 10:31 ` Dave Chinner
2012-04-18 13:33 ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 07/10] xfs: do not write the buffer from xfs_qm_dqflush Christoph Hellwig
2012-04-13 10:33 ` Dave Chinner
2012-04-18 21:11 ` Mark Tinguely [this message]
2012-03-27 16:44 ` [PATCH 08/10] xfs: do not add buffers to the delwri queue until pushed Christoph Hellwig
2012-04-13 10:35 ` Dave Chinner
2012-04-18 21:11 ` Mark Tinguely
2012-03-27 16:44 ` [PATCH 09/10] xfs: on-stack delayed write buffer lists Christoph Hellwig
2012-04-13 11:37 ` Dave Chinner
2012-04-20 18:19 ` Mark Tinguely
2012-04-21 0:42 ` Dave Chinner
2012-04-23 1:57 ` Dave Chinner
2012-03-27 16:44 ` [PATCH 10/10] xfs: remove some obsolete comments in xfs_trans_ail.c Christoph Hellwig
2012-04-13 11:37 ` Dave Chinner
2012-03-28 0:53 ` [PATCH 00/10] remove xfsbufd Dave Chinner
2012-03-28 15:10 ` Christoph Hellwig
2012-03-29 0:52 ` Dave Chinner
2012-03-29 19:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F2E0A.5020807@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.