From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754532Ab2DTNOx (ORCPT ); Fri, 20 Apr 2012 09:14:53 -0400 Received: from antcom.de ([188.40.178.216]:34628 "EHLO chuck.antcom.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751991Ab2DTNOv (ORCPT ); Fri, 20 Apr 2012 09:14:51 -0400 Message-ID: <4F916146.1080904@antcom.de> Date: Fri, 20 Apr 2012 15:14:46 +0200 From: Roland Stigge Organization: ANTCOM IT Research & Development User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: Wolfram Sang CC: grant.likely@secretlab.ca, robherring2@gmail.com, vitalywool@gmail.com, khali@linux-fr.org, ben-linux@fluff.org, rob.herring@calxeda.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, arm@kernel.org, linux-arm-kernel@lists.infradead.org, kevin.wells@nxp.com, Srinivas Bakki Subject: Re: [PATCH v5] i2c: Add device tree support to i2c-pnx.c References: <1334913755-10466-1-git-send-email-stigge@antcom.de> <20120420120950.GA15613@pengutronix.de> In-Reply-To: <20120420120950.GA15613@pengutronix.de> X-Enigmail-Version: 1.3.4 OpenPGP: url=subkeys.pgp.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/20/2012 02:09 PM, Wolfram Sang wrote: >> Signed-off-by: Roland Stigge Reviewed-by: Arnd >> Bergmann Acked-by: Wolfram Sang >> > > NACK! I said the approach of dropping "timeout" is OK, but unless I > say "you may add my ack after changing this and that", please do > not automatically add my ack. Doesn't hurt here, since I have to > pick it up anyway. Sorry - my apologies! Removing for next re-post. >> Changes since v4: * Removed OF timeout property (to be added >> later when there is consensus about how to call and handle it) * >> Changed clock-frequency example to decimal > > Thanks, I just noticed. Please drop (more precise: remove) the > "slave-addr" for the same reasons as "timeout". OK, will do. >> ret = request_irq(alg_data->irq, i2c_pnx_interrupt, - 0, >> pdev->name, alg_data); + 0, pdev->name, alg_data); > > I know that checkpatch complains about this, but I'd prefer to > avoid such changes unless the code before was really unreadable. OK! Roland From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Stigge Subject: Re: [PATCH v5] i2c: Add device tree support to i2c-pnx.c Date: Fri, 20 Apr 2012 15:14:46 +0200 Message-ID: <4F916146.1080904@antcom.de> References: <1334913755-10466-1-git-send-email-stigge@antcom.de> <20120420120950.GA15613@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120420120950.GA15613-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, vitalywool-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kevin.wells-3arQi8VN3Tc@public.gmane.org, Srinivas Bakki List-Id: devicetree@vger.kernel.org Hi, On 04/20/2012 02:09 PM, Wolfram Sang wrote: >> Signed-off-by: Roland Stigge Reviewed-by: Arnd >> Bergmann Acked-by: Wolfram Sang >> > > NACK! I said the approach of dropping "timeout" is OK, but unless I > say "you may add my ack after changing this and that", please do > not automatically add my ack. Doesn't hurt here, since I have to > pick it up anyway. Sorry - my apologies! Removing for next re-post. >> Changes since v4: * Removed OF timeout property (to be added >> later when there is consensus about how to call and handle it) * >> Changed clock-frequency example to decimal > > Thanks, I just noticed. Please drop (more precise: remove) the > "slave-addr" for the same reasons as "timeout". OK, will do. >> ret = request_irq(alg_data->irq, i2c_pnx_interrupt, - 0, >> pdev->name, alg_data); + 0, pdev->name, alg_data); > > I know that checkpatch complains about this, but I'd prefer to > avoid such changes unless the code before was really unreadable. OK! Roland From mboxrd@z Thu Jan 1 00:00:00 1970 From: stigge@antcom.de (Roland Stigge) Date: Fri, 20 Apr 2012 15:14:46 +0200 Subject: [PATCH v5] i2c: Add device tree support to i2c-pnx.c In-Reply-To: <20120420120950.GA15613@pengutronix.de> References: <1334913755-10466-1-git-send-email-stigge@antcom.de> <20120420120950.GA15613@pengutronix.de> Message-ID: <4F916146.1080904@antcom.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 04/20/2012 02:09 PM, Wolfram Sang wrote: >> Signed-off-by: Roland Stigge Reviewed-by: Arnd >> Bergmann Acked-by: Wolfram Sang >> > > NACK! I said the approach of dropping "timeout" is OK, but unless I > say "you may add my ack after changing this and that", please do > not automatically add my ack. Doesn't hurt here, since I have to > pick it up anyway. Sorry - my apologies! Removing for next re-post. >> Changes since v4: * Removed OF timeout property (to be added >> later when there is consensus about how to call and handle it) * >> Changed clock-frequency example to decimal > > Thanks, I just noticed. Please drop (more precise: remove) the > "slave-addr" for the same reasons as "timeout". OK, will do. >> ret = request_irq(alg_data->irq, i2c_pnx_interrupt, - 0, >> pdev->name, alg_data); + 0, pdev->name, alg_data); > > I know that checkpatch complains about this, but I'd prefer to > avoid such changes unless the code before was really unreadable. OK! Roland