From: Caspar Zhang <caspar@casparzhang.com>
To: Jan Stancek <jstancek@redhat.com>
Cc: ltp-list@lists.sourceforge.net, Jeffrey Burke <jburke@redhat.com>
Subject: Re: [LTP] [PATCH 3/3] syscalls/cma: add errno tests
Date: Mon, 23 Apr 2012 19:13:11 +0800 [thread overview]
Message-ID: <4F953947.5060204@casparzhang.com> (raw)
In-Reply-To: <4F952FBC.7040000@redhat.com>
On 04/23/2012 06:32 PM, Jan Stancek wrote:
> Based on proposed man page:
> http://ozlabs.org/~cyeoh/cma/process_vm_readv.txt
>
> Signed-off-by: Jan Stancek <jstancek@redhat.com>
> ---
> testcases/kernel/syscalls/cma/cma01.c | 434 ++++++++++++++++++++
> .../kernel/syscalls/cma/process_vm_readv/Makefile | 7 +
> .../kernel/syscalls/cma/process_vm_writev/Makefile | 7 +
[snip]
> +static void cma_test_params_read(struct process_vm_params *params)
> +{
> +#if (HAVE_PROCESS_VM_READV==1)
> + TEST(process_vm_readv(params->pid,
> + params->lvec, params->liovcnt,
> + params->rvec, params->riovcnt,
> + params->flags));
> +#elif defined(__NR_process_vm_readv)
> + TEST(syscall(__NR_process_vm_readv, params->pid,
> + params->lvec, params->liovcnt,
> + params->rvec, params->riovcnt,
> + params->flags));
> +#else
> + tst_brkm(TCONF, cleanup, "process_vm_readv does not exist on"
> + " your system");
> +#endif
omit other parts since looking good to me.
Still the question left for open-discussion: isn't syscall-only testing
enough, do we need to test glibc wrapper in higher priority?
Thanks,
Caspar
> +}
> +
> +static void cma_test_params_write(struct process_vm_params *params)
> +{
> +#if (HAVE_PROCESS_VM_WRITEV==1)
> + TEST(process_vm_writev(params->pid,
> + params->lvec, params->liovcnt,
> + params->rvec, params->riovcnt,
> + params->flags));
> +#elif defined(__NR_process_vm_writev)
> + TEST(syscall(__NR_process_vm_writev, params->pid,
> + params->lvec, params->liovcnt,
> + params->rvec, params->riovcnt,
> + params->flags));
> +#else
> + tst_brkm(TCONF, cleanup, "process_vm_writev does not exist on"
> + " your system");
> +#endif
> +}
[snip]
------------------------------------------------------------------------------
For Developers, A Lot Can Happen In A Second.
Boundary is the first to Know...and Tell You.
Monitor Your Applications in Ultra-Fine Resolution. Try it FREE!
http://p.sf.net/sfu/Boundary-d2dvs2
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-04-23 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 10:32 [LTP] [PATCH 3/3] syscalls/cma: add errno tests Jan Stancek
2012-04-23 11:13 ` Caspar Zhang [this message]
2012-04-23 12:08 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F953947.5060204@casparzhang.com \
--to=caspar@casparzhang.com \
--cc=jburke@redhat.com \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.