From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from service87.mimecast.com ([91.220.42.44]:58953 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330Ab2DWPtx convert rfc822-to-8bit (ORCPT ); Mon, 23 Apr 2012 11:49:53 -0400 Message-ID: <4F957A0C.7060607@arm.com> Date: Mon, 23 Apr 2012 16:49:32 +0100 From: Marc Zyngier MIME-Version: 1.0 To: viresh kumar CC: "wim@iguana.be" , "spear-devel@list.st.com" , "linux-watchdog@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Pawel Moll , Viresh Kumar Subject: Re: [PATCH V2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog References: <18a4584c24041ceb8a1972dd5ee70cf7c59fed21.1334932839.git.viresh.kumar@st.com> <7dbd64f72527cf92af0ec38f45275d71207d5ec5.1335008301.git.viresh.kumar@st.com> <4F9514AA.10403@arm.com> <4F9547E3.4000709@arm.com> <4F9573B8.9050607@arm.com> In-Reply-To: Content-Type: text/plain; charset=WINDOWS-1252 Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Content-Transfer-Encoding: quoted-printable On 23/04/12 16:33, viresh kumar wrote: > On 4/23/12, Marc Zyngier wrote: >> On 23/04/12 15:21, viresh kumar wrote: >>> On 4/23/12, Marc Zyngier wrote: >>>> Ah, that explains why it worked. I suppose you do have additional >>>> patches that fix the IRQ request bit? >>> >>> Missed this earlier. That patchset is in review currently and have >>> already fixed that. :) >> >> Right. Please post that patch as a prerequisite for any other change. >=20 > Haah!! I misread your question. I don't know how, but i thought you are > asking me to fix this address for SPEAr (My SoC). And that patch set > is currently in review. >=20 > I didn't get this IRQ request bit thing? Can you please explain. The TWD watchdog uses a per-cpu interrupt (usually interrupt #30), and the GIC configuration should flag it as such. With this setup, request_irq() should fail, and the right API is request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq(). So how it works in your environment is a bit puzzling. Unless you're not using GIC? M. --=20 Jazz is not dead. It just smells funny... -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Mon, 23 Apr 2012 16:49:32 +0100 Subject: [PATCH V2] watchdog: mpcore: Add DT probing support for ARM mpcore watchdog In-Reply-To: References: <18a4584c24041ceb8a1972dd5ee70cf7c59fed21.1334932839.git.viresh.kumar@st.com> <7dbd64f72527cf92af0ec38f45275d71207d5ec5.1335008301.git.viresh.kumar@st.com> <4F9514AA.10403@arm.com> <4F9547E3.4000709@arm.com> <4F9573B8.9050607@arm.com> Message-ID: <4F957A0C.7060607@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 23/04/12 16:33, viresh kumar wrote: > On 4/23/12, Marc Zyngier wrote: >> On 23/04/12 15:21, viresh kumar wrote: >>> On 4/23/12, Marc Zyngier wrote: >>>> Ah, that explains why it worked. I suppose you do have additional >>>> patches that fix the IRQ request bit? >>> >>> Missed this earlier. That patchset is in review currently and have >>> already fixed that. :) >> >> Right. Please post that patch as a prerequisite for any other change. > > Haah!! I misread your question. I don't know how, but i thought you are > asking me to fix this address for SPEAr (My SoC). And that patch set > is currently in review. > > I didn't get this IRQ request bit thing? Can you please explain. The TWD watchdog uses a per-cpu interrupt (usually interrupt #30), and the GIC configuration should flag it as such. With this setup, request_irq() should fail, and the right API is request_percpu_irq(), together with enable_percpu_irq()/disable_percpu_irq(). So how it works in your environment is a bit puzzling. Unless you're not using GIC? M. -- Jazz is not dead. It just smells funny...