From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH 4/8] staging:iio:dac:ad5446: Remove duplicated chip_info entries
Date: Mon, 23 Apr 2012 21:44:19 +0100 [thread overview]
Message-ID: <4F95BF23.2070603@kernel.org> (raw)
In-Reply-To: <1335203497-11041-4-git-send-email-lars@metafoo.de>
On 04/23/2012 06:51 PM, Lars-Peter Clausen wrote:
> There are three identical chip_info entries. Remove two of them and use the id
> of the remaining entry for all three device table entries.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/dac/ad5446.c | 12 ++----------
> drivers/staging/iio/dac/ad5446.h | 2 --
> 2 files changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/ad5446.c b/drivers/staging/iio/dac/ad5446.c
> index 9d9a452..693485a 100644
> --- a/drivers/staging/iio/dac/ad5446.c
> +++ b/drivers/staging/iio/dac/ad5446.c
> @@ -176,14 +176,6 @@ static const struct ad5446_chip_info ad5446_chip_info_tbl[] = {
> .channel = AD5446_CHANNEL(16, 16, 0),
> .store_sample = ad5542_store_sample,
> },
> - [ID_AD5542A] = {
> - .channel = AD5446_CHANNEL(16, 16, 0),
> - .store_sample = ad5542_store_sample,
> - },
> - [ID_AD5543] = {
> - .channel = AD5446_CHANNEL(16, 16, 0),
> - .store_sample = ad5542_store_sample,
> - },
> [ID_AD5512A] = {
> .channel = AD5446_CHANNEL(12, 16, 4),
> .store_sample = ad5542_store_sample,
> @@ -400,8 +392,8 @@ static const struct spi_device_id ad5446_id[] = {
> {"ad5446", ID_AD5446},
> {"ad5512a", ID_AD5512A},
> {"ad5541a", ID_AD5541A},
> - {"ad5542a", ID_AD5542A},
> - {"ad5543", ID_AD5543},
> + {"ad5542a", ID_AD5541A}, /* ad5541a and ad5542a are compatible */
> + {"ad5543", ID_AD5541A}, /* ad5541a and ad5543 are compatible */
> {"ad5553", ID_AD5553},
> {"ad5601", ID_AD5601},
> {"ad5611", ID_AD5611},
> diff --git a/drivers/staging/iio/dac/ad5446.h b/drivers/staging/iio/dac/ad5446.h
> index 72ad07f..264df1e 100644
> --- a/drivers/staging/iio/dac/ad5446.h
> +++ b/drivers/staging/iio/dac/ad5446.h
> @@ -83,8 +83,6 @@ enum ad5446_supported_device_ids {
> ID_AD5444,
> ID_AD5446,
> ID_AD5541A,
> - ID_AD5542A,
> - ID_AD5543,
> ID_AD5512A,
> ID_AD5553,
> ID_AD5601,
next prev parent reply other threads:[~2012-04-23 20:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 17:51 [PATCH 1/8] staging:iio:dac:ad5446: Do not exit powerdown when writing a sample Lars-Peter Clausen
2012-04-23 17:51 ` [PATCH 2/8] staging:iio:dac:ad5446: Remove unused struct field Lars-Peter Clausen
2012-04-23 20:41 ` Jonathan Cameron
2012-04-23 17:51 ` [PATCH 3/8] staging:iio:dac:ad5446: Do not check for individual chip ids in probe Lars-Peter Clausen
2012-04-23 20:43 ` Jonathan Cameron
2012-04-23 17:51 ` [PATCH 4/8] staging:iio:dac:ad5446: Remove duplicated chip_info entries Lars-Peter Clausen
2012-04-23 20:44 ` Jonathan Cameron [this message]
2012-04-23 17:51 ` [PATCH 5/8] staging:iio:dac:ad5446: Remove duplicated write sample functions Lars-Peter Clausen
2012-04-23 21:15 ` Jonathan Cameron
2012-04-23 17:51 ` [PATCH 6/8] staging:iio:dac:ad5446: Convert to extended channel attributes Lars-Peter Clausen
2012-04-23 21:25 ` Jonathan Cameron
2012-04-23 17:51 ` [PATCH 7/8] staging:iio:dac:ad5446: Consolidate store_sample and store_pwr_down functions Lars-Peter Clausen
2012-04-24 8:06 ` Jonathan Cameron
2012-04-24 9:11 ` Lars-Peter Clausen
2012-04-24 9:10 ` Jonathan Cameron
2012-04-23 17:51 ` [PATCH 8/8] staging:iio:dac:ad5446: Add support for the AD5662 Lars-Peter Clausen
2012-04-24 8:10 ` Jonathan Cameron
2012-04-23 20:40 ` [PATCH 1/8] staging:iio:dac:ad5446: Do not exit powerdown when writing a sample Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F95BF23.2070603@kernel.org \
--to=jic23@kernel.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.