From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SMbnS-0001w0-Vo for mharc-grub-devel@gnu.org; Tue, 24 Apr 2012 05:12:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMbnM-0001vk-Fy for grub-devel@gnu.org; Tue, 24 Apr 2012 05:12:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMbnF-0007zs-Gb for grub-devel@gnu.org; Tue, 24 Apr 2012 05:12:24 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:51086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMbnF-0007ze-7W for grub-devel@gnu.org; Tue, 24 Apr 2012 05:12:17 -0400 Received: by wgbdr1 with SMTP id dr1so351996wgb.30 for ; Tue, 24 Apr 2012 02:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; bh=iU3hfFswuAxnf1xYmt5FkD5foRom9ImheYGt+oTS5d4=; b=X7mdhFS6Er53zwsyARjbCTzlCoZVHpk8gvFk/dFDDoZf4CxGfnb3MRywu9nbrLdd1S c5XKlMpPajHMYPrm/gANRRrEH1b1faoqXnAyQ9PaoUBkuTH6N8pgateSOj64ndixhijR jSq+WPaC0d7sDtSx2DkT7uPfaff68Oy2Wvx5atWopYxtxYGnXQUww5AoPM5dKgAXt9zn hMVCVP9vkP/d6paxiitwgvYiowWhlbukBJ+1SGq2Sii0lrq9M2QaWCudBhcCyE7gjqok fiur+y+PByV2Z8Mx/PGUaOzxg9wqq5d1Y33zEVwAeWpZs+oKH9ER6z88BgiN6Gxyt5FR 98Qw== Received: by 10.216.225.216 with SMTP id z66mr11907478wep.71.1335258735309; Tue, 24 Apr 2012 02:12:15 -0700 (PDT) Received: from debian.x201.phnet (39-234.197-178.cust.bluewin.ch. [178.197.234.39]) by mx.google.com with ESMTPS id k6sm28688096wie.9.2012.04.24.02.12.13 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 24 Apr 2012 02:12:14 -0700 (PDT) Message-ID: <4F966E6B.7010306@gmail.com> Date: Tue, 24 Apr 2012 11:12:11 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120329 Icedove/10.0.3 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH,HURD] Fix grub-probe with userland partition support References: <20120422182439.GE4755@type.famille.thibault.fr> <4F951839.4070309@gmail.com> <20120423094030.GB4755@type.famille.thibault.fr> <4F9532B5.9050701@gmail.com> <20120423110627.GL4755@type.famille.thibault.fr> <4F953A3B.3000708@gmail.com> <20120423212606.GV4755@type.famille.thibault.fr> <20120423233423.GC4755@type.famille.thibault.fr> <4F966A79.8050700@gmail.com> <20120424090056.GB4453@type.bordeaux.inria.fr> In-Reply-To: <20120424090056.GB4453@type.bordeaux.inria.fr> X-Enigmail-Version: 1.4 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig7437C5FA73EDBAAD3E2D90F7" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2012 09:12:30 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7437C5FA73EDBAAD3E2D90F7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.04.2012 11:00, Samuel Thibault wrote: > Vladimir '=CF=86-coder/phcoder' Serbinenko, le Tue 24 Apr 2012 10:55:21= +0200, a =C3=A9crit : >> On 24.04.2012 01:34, Samuel Thibault wrote: >>> + if (errno =3D=3D ENOENT && part >=3D 5) >>> + { >> This introduces an assumption that if part >=3D5 is missing then there= are >> no additional partitions. While this is true for msdos, it's false for= >> GPT, where such config is common after deleting a partition. Moreover,= >> APM (apple) partitions often start at 8. > Ok, but what do you suggest? By the very nature of parted-based > translators, there is no way to know how many partitions there are. Can we know whether given device is partition? If we know that it is we can iterate as long as we can, adding some restriction like your 1000 and issuing error if it's hit since it should never happen. --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig7437C5FA73EDBAAD3E2D90F7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iF4EAREKAAYFAk+WbmsACgkQNak7dOguQgndYwEAlU6mog321YdQec2S9MYfDAZ1 aIcOuQbiHAwTTqtJN1IBAJmDJl9aTxZcnc2RKFyOZEXqZ5GnU4pOfwEbSYrgDcU0 =c7kY -----END PGP SIGNATURE----- --------------enig7437C5FA73EDBAAD3E2D90F7--