[PATCH] mfd/tps65910: fix section mismatch in linux-next

[PATCH] mfd/tps65910: fix section mismatch in linux-next

[Gerard Snitselaar]

tps65910_i2c_probe() calls tps65910_sleepinit() which is annnotated __init.

Signed-off-by: Gerard Snitselaar <dev@snitselaar.org>
---
 drivers/mfd/tps65910.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index ae7f47b..c050ae5 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -150,7 +150,7 @@ err_sleep_init:
 }
 
 
-static int tps65910_i2c_probe(struct i2c_client *i2c,
+static int __init tps65910_i2c_probe(struct i2c_client *i2c,
 			    const struct i2c_device_id *id)
 {
 	struct tps65910 *tps65910;
-- 
1.7.7.6

Re: [PATCH] mfd/tps65910: fix section mismatch in linux-next

[Stephen Warren]

On 04/24/2012 09:13 AM, Gerard Snitselaar wrote:
> tps65910_i2c_probe() calls tps65910_sleepinit() which is annnotated __init.

> -static int tps65910_i2c_probe(struct i2c_client *i2c,
> +static int __init tps65910_i2c_probe(struct i2c_client *i2c,

Shouldn't this be __devinit not __init?

Re: [PATCH] mfd/tps65910: fix section mismatch in linux-next

[Laxman Dewangan]

On Tuesday 24 April 2012 08:43 PM, Gerard Snitselaar wrote:
> tps65910_i2c_probe() calls tps65910_sleepinit() which is annnotated __init.
>
> Signed-off-by: Gerard Snitselaar<dev@snitselaar.org>
> ---
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

Re: [PATCH] mfd/tps65910: fix section mismatch in linux-next

[Mark Brown]

On Tue, Apr 24, 2012 at 08:13:55AM -0700, Gerard Snitselaar wrote:

> -static int tps65910_i2c_probe(struct i2c_client *i2c,
> +static int __init tps65910_i2c_probe(struct i2c_client *i2c,
>  			    const struct i2c_device_id *id)

I sent a separate fix for this earlier on - __init is the wrong
annotation here, a device init function should be marked __devinit.

Re: [PATCH] mfd/tps65910: fix section mismatch in linux-next

[Gerard Snitselaar]

On Thu Apr 26 12, Mark Brown wrote:
> On Tue, Apr 24, 2012 at 08:13:55AM -0700, Gerard Snitselaar wrote:
> 
> > -static int tps65910_i2c_probe(struct i2c_client *i2c,
> > +static int __init tps65910_i2c_probe(struct i2c_client *i2c,
> >  			    const struct i2c_device_id *id)
> 
> I sent a separate fix for this earlier on - __init is the wrong
> annotation here, a device init function should be marked __devinit.

I missed your patch when I did a search initially. Does it also change the annotation of tps65910_sleepinit() to __devinit ? If all devices are supposed to have their init functions annotated __devinit is the comment in correct in init.h which says the __dev* annotations are used for HOTPLUG? Is this power management chip hotpluggable?