From: Frederic Danis <frederic.danis@linux.intel.com>
To: ofono@ofono.org
Subject: Re: [RFC v4 09/10] hfp_ag: Add media transport support
Date: Tue, 24 Apr 2012 18:19:51 +0200 [thread overview]
Message-ID: <4F96D2A7.1090903@linux.intel.com> (raw)
In-Reply-To: <4F7F29FA.5060106@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hello Denis,
Le 06/04/2012 19:38, Denis Kenzior a écrit :
> Hi Frédéric,
>
>> @@ -82,6 +93,12 @@ static DBusMessage *hfp_ag_agent_new_connection(DBusConnection *conn,
>> return __ofono_error_failed(msg);
>>
>> ofono_emulator_register(em, fd);
>> + audio = bluetooth_set_audio_management(em, path, features);
>> +
>> + io = g_io_channel_unix_new(fd);
>> + g_io_add_watch_full(io, G_PRIORITY_HIGH,
>> + G_IO_HUP | G_IO_ERR | G_IO_NVAL, client_event,
>> + audio, NULL);
>
> It might be better to register to atom removal rather than an IO watch.
As modem can have multiple emulator atoms (in case of connection to
multiple headsets), I do not think that registering for atom removal
using __ofono_modem_add_atom_watch() will be OK.
I may add an API to emulator to register a disconnection callback:
ofono_emulator_set_disconnect_cb(em, cb, cb_data)
This keep separation between oFono core and HFP AG plug-in.
Regards
Fred
--
Frederic Danis Open Source Technology Center
frederic.danis(a)intel.com Intel Corporation
next prev parent reply other threads:[~2012-04-24 16:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 13:17 [RFC v4 00/10] org.bluez.Telephony interface integration =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 01/10] bluetooth: Add org.bluez.Telephony helpers =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 02/10] hfp_hf: Update to org.bluez.Telephony interface =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 03/10] hfp_ag: " =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 04/10] bluetooth: Add audio APIs for HFP AG =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 17:27 ` Denis Kenzior
2012-04-06 13:17 ` [RFC v4 05/10] bluetooth: Add AT+NREC support =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 17:32 ` Denis Kenzior
2012-04-06 13:17 ` [RFC v4 06/10] bluetooth: Add +BSIR support =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 07/10] bluetooth: Add AT+VGM support =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 08/10] bluetooth: Add AT+VGS support =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 13:17 ` [RFC v4 09/10] hfp_ag: Add media transport support =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 17:38 ` Denis Kenzior
2012-04-24 16:19 ` Frederic Danis [this message]
2012-04-23 19:24 ` Denis Kenzior
2012-04-06 13:17 ` [RFC v4 10/10] emulator: Update supported features =?unknown-8bit?q?Fr=C3=A9d=C3=A9ric?= Danis
2012-04-06 17:38 ` Denis Kenzior
2012-04-23 14:01 ` Frederic Danis
2012-04-23 0:03 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F96D2A7.1090903@linux.intel.com \
--to=frederic.danis@linux.intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.