From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 1/3v2] kvm-s390: Implement the directed yield (diag 9c) hypervisor call for KVM Date: Tue, 24 Apr 2012 18:21:03 +0200 Message-ID: <4F96D2EF.1070505@de.ibm.com> References: <4F96A021.4000704@de.ibm.com> <1335272114-64505-1-git-send-email-borntraeger@de.ibm.com> <4F96A55E.1050703@redhat.com> <4F96CB16.8060700@de.ibm.com> <4F96D1B2.7040901@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marcelo Tossati , Carsten Otte , Alexander Graf , Jens Freimann , Cornelia Huck , Heiko Carstens , Martin Schwidefsky , Heinz Graalfs , KVM , Konstantin Weitz To: Avi Kivity Return-path: Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:58245 "EHLO e06smtp18.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755770Ab2DXQVD (ORCPT ); Tue, 24 Apr 2012 12:21:03 -0400 Received: from /spool/local by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Apr 2012 17:21:01 +0100 Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3OGKxbe2519278 for ; Tue, 24 Apr 2012 17:20:59 +0100 Received: from d06av09.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q3OGKw4A013346 for ; Tue, 24 Apr 2012 10:20:59 -0600 In-Reply-To: <4F96D1B2.7040901@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 24/04/12 18:15, Avi Kivity wrote: >>> instead of looking like you're doing the processing for every vcpu. The >>> loop is just a slow lookup which might some day be replaced by a table >>> lookup. >> >> Ok. We might also have a kvm_vcpu_on_spin_directed in common code, >> Would you prefer that? > > You mean a function that takes a vcpu and tries to yield_to() it? Or > something else? Or a cpu id (number). But yes, something like that. I dont know if that will be of use for x86 (e.g. parvirtual ticketlocks or something like that). Christian