All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Malcolm Crossley <malcolm.crossley@citrix.com>
Cc: "Tim (Xen.org)" <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] [RFC] xen: Fix memory hotplug end limit test for updating compat M2P table
Date: Tue, 24 Apr 2012 17:11:59 +0100	[thread overview]
Message-ID: <4F96ECEF020000780007FB36@nat28.tlf.novell.com> (raw)
In-Reply-To: <4F96CE7A.2030906@citrix.com>

>>> On 24.04.12 at 18:02, Malcolm Crossley <malcolm.crossley@citrix.com> wrote:
> The key fix is the patch is that epfn is being compared to 
> (RDWR_COMPAT_MPT_VIRT_END - RDWR_COMPAT_MPT_VIRT_START)
> without a 2 bit shift.

Ah, okay, that was well hidden among all the other changes you did,
and at least I wasn't able to decode this from the patch description.

> This means that epfn is being compared to the size of the RDWR_COMPAT_MPT 
> table instead of the maximum number of
> entries the RDWR_COMPAT_MPT table can contain. This could result in the end 
> regions of hotplugged memory being
> inaccessible when using the RDWR_COMPAT_MPT table.
> 
> I also moved the epfn masking to occur before the comparison to 
> RDWR_COMPAT_MPT to be consistent with the
> spfn comparison code.
> 
> I can split the patch for to make the changes clearer if you want?

I'm really not certain all the other changes really matter in any way,
so I'd really like to ask for a patch just adding the missing shift.

Jan

      reply	other threads:[~2012-04-24 16:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 18:07 [PATCH] [RFC] xen: Fix memory hotplug end limit test for updating compat M2P table Malcolm Crossley
2012-04-24  7:21 ` Jan Beulich
2012-04-24 16:02   ` Malcolm Crossley
2012-04-24 16:11     ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F96ECEF020000780007FB36@nat28.tlf.novell.com \
    --to=jbeulich@suse.com \
    --cc=malcolm.crossley@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.